Address gosec and staticcheck linter warnings#358
Closed
asnyatkov wants to merge 1 commit intopion:masterfrom
Closed
Address gosec and staticcheck linter warnings#358asnyatkov wants to merge 1 commit intopion:masterfrom
asnyatkov wants to merge 1 commit intopion:masterfrom
Conversation
Add nolint directives for safe integer conversions and slice accesses that are already bounds-checked. Replace WriteString(Sprintf(...)) with Fprintf.
JoTurk
requested changes
Mar 26, 2026
Member
JoTurk
left a comment
There was a problem hiding this comment.
Thank you, this is related to our lint upgrade can you do it in #356
for reference we update our lint settings like this pion/dtls#803
in the next upgrade we're going to split settings so it doesn't break repos until we upgrade,
I'll invite you to the org so you can push commits to the branch directly
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 82.59% 82.59%
=======================================
Files 28 28
Lines 3430 3430
=======================================
Hits 2833 2833
Misses 427 427
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add nolint directives for safe integer conversions and slice accesses that are already bounds-checked. Replace WriteString(Sprintf(...)) with Fprintf.