Skip to content

Address gosec and staticcheck linter warnings#358

Closed
asnyatkov wants to merge 1 commit intopion:masterfrom
asnyatkov:fix/linter-warnings
Closed

Address gosec and staticcheck linter warnings#358
asnyatkov wants to merge 1 commit intopion:masterfrom
asnyatkov:fix/linter-warnings

Conversation

@asnyatkov
Copy link
Copy Markdown
Contributor

Description

Add nolint directives for safe integer conversions and slice accesses that are already bounds-checked. Replace WriteString(Sprintf(...)) with Fprintf.

Add nolint directives for safe integer conversions and slice accesses
that are already bounds-checked. Replace WriteString(Sprintf(...)) with
Fprintf.
Copy link
Copy Markdown
Member

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is related to our lint upgrade can you do it in #356

for reference we update our lint settings like this pion/dtls#803

in the next upgrade we're going to split settings so it doesn't break repos until we upgrade,
I'll invite you to the org so you can push commits to the branch directly

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.59%. Comparing base (e119a01) to head (319e178).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files          28       28           
  Lines        3430     3430           
=======================================
  Hits         2833     2833           
  Misses        427      427           
  Partials      170      170           
Flag Coverage Δ
go 82.59% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asnyatkov asnyatkov closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants