Validate zero padding size on unmarshal#357
Merged
JoTurk merged 1 commit intopion:masterfrom Mar 26, 2026
Merged
Conversation
RFC 3550 requires the padding byte to be non-zero when the padding bit is set. Marshal already validates this (errInvalidRTPPadding), but unmarshal does not, allowing malformed packets through. This is related to CVE-2025-49140 in pion/interceptor which addressed improper RTP padding handling.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
==========================================
+ Coverage 82.59% 82.60% +0.01%
==========================================
Files 28 28
Lines 3430 3432 +2
==========================================
+ Hits 2833 2835 +2
Misses 427 427
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
approved these changes
Mar 26, 2026
Member
|
thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 3550 requires the padding byte to be non-zero when the padding bit is set. Marshal already validates this (errInvalidRTPPadding), but unmarshal does not, allowing malformed packets through.
This is related to CVE-2025-49140 in pion/interceptor which addressed improper RTP padding handling.
Description
Reference issue
Fixes #...