Use Go 1.21 built-in min function#355
Merged
cppcoffee merged 1 commit intopion:masterfrom Sep 10, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #355 +/- ##
==========================================
+ Coverage 78.71% 78.78% +0.07%
==========================================
Files 82 82
Lines 5169 5139 -30
==========================================
- Hits 4069 4049 -20
+ Misses 927 920 -7
+ Partials 173 170 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hello I changed this PR to a draft until we upgrade to go 1.21. We can't right now because it will force many users to stuck with older version of pion! |
JoTurk
approved these changes
Sep 9, 2025
Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request proposes an update to the Go version, elevating it from 1.20 to 1.21.
This change is dependent on pion/.goassets#233