Skip to content

Use Go 1.21 built-in min function#355

Merged
cppcoffee merged 1 commit intopion:masterfrom
cppcoffee:min
Sep 10, 2025
Merged

Use Go 1.21 built-in min function#355
cppcoffee merged 1 commit intopion:masterfrom
cppcoffee:min

Conversation

@cppcoffee
Copy link
Member

@cppcoffee cppcoffee commented Aug 10, 2025

This pull request proposes an update to the Go version, elevating it from 1.20 to 1.21.

This change is dependent on pion/.goassets#233

@codecov
Copy link

codecov bot commented Aug 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.78%. Comparing base (ff2807d) to head (578fc25).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   78.71%   78.78%   +0.07%     
==========================================
  Files          82       82              
  Lines        5169     5139      -30     
==========================================
- Hits         4069     4049      -20     
+ Misses        927      920       -7     
+ Partials      173      170       -3     
Flag Coverage Δ
go 78.67% <100.00%> (-0.05%) ⬇️
wasm 76.27% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk JoTurk marked this pull request as draft August 10, 2025 16:01
@JoTurk
Copy link
Member

JoTurk commented Aug 10, 2025

Hello I changed this PR to a draft until we upgrade to go 1.21. We can't right now because it will force many users to stuck with older version of pion!

Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
@cppcoffee cppcoffee merged commit 28775a6 into pion:master Sep 10, 2025
14 checks passed
@cppcoffee cppcoffee deleted the min branch September 10, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants