Remove unused named return parameters#354
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
==========================================
- Coverage 78.70% 78.64% -0.06%
==========================================
Files 82 82
Lines 5165 5165
==========================================
- Hits 4065 4062 -3
- Misses 927 929 +2
- Partials 173 174 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cppcoffee
changed the title
cppcoffee
force-pushed
the
master
branch
2 times, most recently
from
5d6361e to
6f716df
Compare
JoTurk
left a comment
JoTurk
left a comment
There was a problem hiding this comment.
Thank you for all the improvements you do <3
pkg/twcc/arrival_time_map.go
Outdated
| @@ -106,11 +106,11 @@ func (m *packetArrivalTimeMap) EndSequenceNumber() int64 { | |||
| // FindNextAtOrAfter returns the sequence number and timestamp of the first received packet that has a sequence number | |||
| // greator or equal to sequenceNumber. | |||
There was a problem hiding this comment.
Not related to your PR but there is a typo greator.
| // FindNextAtOrAfter returns the sequence number and timestamp of the first received packet that has a sequence number | ||
| // greator or equal to sequenceNumber. | ||
| func (m *packetArrivalTimeMap) FindNextAtOrAfter(sequenceNumber int64) ( | ||
| foundSequenceNumber int64, arrivalTime int64, ok bool, |
There was a problem hiding this comment.
I like this change but I think it makes this function slightly less readable from foundSequenceNumber int64, arrivalTime int64, ok bool int64, int64, bool, maybe we can move this to the function comment? or name the local variables to foundSequenceNumber and arrivalTime instead of seq and t.
There was a problem hiding this comment.
Perhaps designating them 'seq' and 'arrivalTime' would ensure adherence to the 72-character constraint.
Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
2 participants
Remove unused named return parameters from
FindNextAtOrAftermethod as they were not being used in the function implementation.