Fix jitter calculation to match RFC3550 and convert to seconds#352
Merged
kevmo314 merged 1 commit intopion:masterfrom Aug 17, 2025
Merged
Fix jitter calculation to match RFC3550 and convert to seconds#352kevmo314 merged 1 commit intopion:masterfrom
kevmo314 merged 1 commit intopion:masterfrom
Conversation
kevmo314
approved these changes
Aug 17, 2025
Contributor
Author
|
I rebased onto the current master branch which should hopefully fix the linter issue |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
==========================================
- Coverage 78.70% 78.60% -0.10%
==========================================
Files 82 82
Lines 5165 5169 +4
==========================================
- Hits 4065 4063 -2
- Misses 927 931 +4
- Partials 173 175 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This change seems reasonable to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The previous jitter calculation was not following RFC3550 and reported incorrect values, as can be seen in the first modified test which reports a high jitter despite all packets arriving perfectly spaced (in both RTP timestamp and Pion receival timestamp).
Additionally, other implementations report the jitter in seconds instead of RTP timestamp units which are dependent on the streams clock rate, which should now also be the case here.
Reference issue
Fixes #234