Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 77.65% 78.44% +0.78%
==========================================
Files 80 81 +1
Lines 5080 5130 +50
==========================================
+ Hits 3945 4024 +79
+ Misses 960 929 -31
- Partials 175 177 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
left a comment
There was a problem hiding this comment.
I can confirm it's working, This is great, thank you so much <3
0a3b45d to
19ea653
Compare
|
I think we shouldn't keep FlexEncoder20 in the public API until it's working, so compatibility check is red. @joeturki, do you think it's ok to bypass the rules here? |
In one hand interceptor is version 0, so breaking changes like this is expected and this removes already broken API, so it's probably not used on production anywhere, on the other hand I don't see a problem of keeping until it's fixed. @Sean-Der what do you think? |
|
@joeturki, I have returned the broken API – I'm fine with that |
Description
Reference issue
Fixes #332