test: stabilize flaky TestAnalyzeHighestPriorityTablesWithFailedAnalysis

[flaky-claw]

What problem does this PR solve?

Issue Number: close #68123

Problem Summary:
Flaky test TestAnalyzeHighestPriorityTablesWithFailedAnalysis in pkg/statistics/handle/autoanalyze/refresher intermittently fails, so this PR stabilizes that path.

What changed and how does it work?

Root Cause

The flaky root cause remains a TEST_ISSUE where the case accidentally used partitioned t2 and entered an unrelated dynamic-partition analyze race, while this address round fixes only the missing Bazel direct dep for the staged intest import.

Fix

Adding //pkg/util/intest to refresher_test is necessary because main_test.go now imports github.com/pingcap/tidb/pkg/util/intest directly and Bazel strict-deps must reflect that import explicitly.

Verification

Spec:

• target: pkg/statistics/handle/autoanalyze/refresher :: TestAnalyzeHighestPriorityTablesWithFailedAnalysis
• strategy: tidb.go_flaky.default
• plan mode: BASELINE_ONLY
• requirements: required case must execute; no skip; repeat count = 1
• baseline gates: required_flaky_gate, build_safety_gate, intent_guard_gate
• feedback surface source: baseline_only

Observed result:

• status: passed
• required case executed: yes
• submission decision: ALLOWED
• note: Required flaky case executed during validation.
  Required flaky case was not skipped.
  Required flaky gate passed.
  Affected scope regression gate passed.
  Build safety gate passed.
  Intent guard gate passed.

Gate checklist:

• Required flaky gate: PASS
• Affected scope regression gate: PASS
• Build safety gate: PASS
• Intent guard gate: PASS
• Repo-wide advisory gate: SKIPPED
• Feedback specific gate: SKIPPED

Commands:

• go test -json ./pkg/statistics/handle/autoanalyze/refresher -run '^TestAnalyzeHighestPriorityTablesWithFailedAnalysis$' -count=1
• go test -json ./pkg/statistics/handle/autoanalyze/refresher -count=1
• make build

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Fixes #68123

Summary by CodeRabbit

• Tests
  • Enhanced test infrastructure and initialization procedures for improved validation during test execution.

Note: This release contains internal test improvements with no user-visible changes.

[pantheon-ai]

The master agent encountered an error while processing. Please try again later.

_{ℹ️ Learn more details on Pantheon AI.}

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 0xpoe for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/statistics/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tiprow]

Hi @flaky-claw. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR addresses a flaky test by enabling test-mode initialization in the test entrypoint and adding the required dependency. The test logic is simplified by replacing a partitioned table with a non-partitioned one, reducing complexity in the test scenario.

Changes

Cohort / File(s)	Summary
Build configuration pkg/statistics/handle/autoanalyze/refresher/BUILD.bazel	Added //pkg/util/intest test dependency to the refresher_test target.
Test initialization pkg/statistics/handle/autoanalyze/refresher/main_test.go	Updated TestMain to initialize intest module with InTest, EnableAssert, and EnableInternalCheck flags before test setup and validation.
Test logic simplification pkg/statistics/handle/autoanalyze/refresher/refresher_test.go	Modified TestAnalyzeHighestPriorityTablesWithFailedAnalysis to use a non-partitioned table instead of partitioned, adjusting physical table stats retrieval to use table ID directly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• executor, statistics: flush pending stats delta before analyze #67939: Enables intest module in pkg/statistics tests and implements single-node test path logic that this PR's test initialization now activates.

Suggested labels

component/statistics, size/XS, ok-to-test

Suggested reviewers

• henrybw
• 0xPoe
• terry1purcell

Poem

🐰 A flaky test hops and hides,
But intest brings it to light!
Partitions fade to simplicity,
Now stable through the night,
The refresher test runs true! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The PR description follows the template structure with issue number, problem summary, detailed explanation of changes, verification steps, and completed checklist.
Linked Issues check	✅ Passed	The PR successfully addresses the flaky test stabilization objective from issue #68123 by adding the missing Bazel dependency and adjusting test logic.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to stabilizing the flaky test: Bazel dependency addition, test initialization, and test logic adjustment for table partitioning.
Title check	✅ Passed	The title clearly summarizes the main change: stabilizing a flaky test. It directly maps to the primary objective and the substantial test logic changes across multiple files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.6183%. Comparing base (0e5e814) to head (779cf2c).

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #68124        +/-   ##
================================================
- Coverage   77.7559%   77.6183%   -0.1376%     
================================================
  Files          1990       1984         -6     
  Lines        551769     556152      +4383     
================================================
+ Hits         429033     431676      +2643     
- Misses       121816     123729      +1913     
+ Partials        920        747       -173     

Flag	Coverage Δ
integration	43.7157% <ø> (+3.9138%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	60.4888% <ø> (ø)
parser	∅ <ø> (∅)
br	50.0597% <ø> (-13.0338%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[yinsustart]

/check-issue-triage-complete