Add ability to discover devices on all local interfaces (subnets)#18
Open
tempelmann wants to merge 3 commits intopierrickrouxel:mainfrom
Open
Add ability to discover devices on all local interfaces (subnets)#18tempelmann wants to merge 3 commits intopierrickrouxel:mainfrom
tempelmann wants to merge 3 commits intopierrickrouxel:mainfrom
Conversation
…P addresses of the local interfaces to the parameter `onInterfaces:`. You can pass the values from the `getIFAddresses` function from https://stackoverflow.com/a/25627545/43615 for this purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve issue #17
I had to disable the code that would abort the discovery if there's an error with the socket, as it's now possible that some of the specified interfaces fail (e.g. due to "not reachable"), yet we want the rest to continue to work.
If all of them fail, then I report that the search is finished, though I'm not sure if that may run into a race condition. Or maybe one should in that special case still report an error.
I leave that up to you. The way it's now it works nicely for me.
Hope this helps, and thank you for providing this code in the first place!