Add Access-Control-Allow-Origin to remote-access responses#100
Open
m10653 wants to merge 2 commits into
Open
Conversation
Member
|
Thanks, makes perfect sense. In fact, I just discussed a use-case two days ago where CORS could be a headache. I plan to merge our current development branches over the next days to finally work on a beta for the next release and I will include this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Access-Control-Allow-Origin: *to all responses served by theremote-access HTTP server, so cross-origin browser pages can read from
the API.
Motivation
Lack of CORS headers makes it hard to build standalone dashboards, bookmarklets,websites, or static
HTML tools that talk to a Phyphox phone app even when the user is on the same local network.
I'm aware this PR may not be accepted as relaxing CORS on the server does have some security implications.