Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,9 @@ jobs:
OUTPUT=$(../bashunit -a exit_code "1" "../../bin/phpstan")
echo "$OUTPUT"
../bashunit -a contains 'Method StubFiles\Foo::doFoo() has no return type specified.' "$OUTPUT"
- script: |
cd e2e/nested-trait-use
../../bin/phpstan analyze
steps:
- name: "Checkout"
Expand Down
5 changes: 5 additions & 0 deletions e2e/nested-trait-use/framework/Builder.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?php

namespace NestedTraitUse\Framework;

class Builder {}
13 changes: 13 additions & 0 deletions e2e/nested-trait-use/framework/HasBuilder.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace NestedTraitUse\Framework;

/** @template TBuilder of Builder */
trait HasBuilder
{
/** @return TBuilder */
public function newBuilder(): Builder
{
return parent::newBuilder();
}
}
14 changes: 14 additions & 0 deletions e2e/nested-trait-use/framework/Model.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?php

namespace NestedTraitUse\Framework;

class Model
{
/** @var class-string<Builder> */
protected static string $builder = Builder::class;

public function newBuilder(): Builder
{
return new static::$builder();
}
}
10 changes: 10 additions & 0 deletions e2e/nested-trait-use/main.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use NestedTraitUse\Src\ChildModel;

use function PHPStan\Testing\assertType;

function test(ChildModel $model): void
{
assertType('NestedTraitUse\Src\CustomBuilder', $model->newBuilder());
}
8 changes: 8 additions & 0 deletions e2e/nested-trait-use/phpstan.neon
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
parameters:
level: 9
tmpDir: tmp
paths:
- main.php
scanDirectories:
- src
- framework
12 changes: 12 additions & 0 deletions e2e/nested-trait-use/src/ChildModel.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?php

namespace NestedTraitUse\Src;

use NestedTraitUse\Framework\Model;

class ChildModel extends Model
{
/** @use HasBuilder<CustomBuilder> */
use HasBuilder;
protected static string $builder = CustomBuilder::class;
}
7 changes: 7 additions & 0 deletions e2e/nested-trait-use/src/CustomBuilder.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?php

namespace NestedTraitUse\Src;

use NestedTraitUse\Framework\Builder;

class CustomBuilder extends Builder {}
13 changes: 13 additions & 0 deletions e2e/nested-trait-use/src/HasBuilder.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace NestedTraitUse\Src;

use NestedTraitUse\Framework\Builder;
use NestedTraitUse\Framework\HasBuilder as BaseHasBuilder;

/** @template TBuilder of Builder */
trait HasBuilder
{
/** @use BaseHasBuilder<TBuilder> */
use BaseHasBuilder;
}
2 changes: 2 additions & 0 deletions e2e/nested-trait-use/tmp/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
*
!.gitignore
4 changes: 2 additions & 2 deletions src/Type/FileTypeMapper.php
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ private function getNameScopeMap(string $fileName): array
{
if (!isset($this->memoryCache[$fileName])) {
$cacheKey = sprintf('ftm-%s', $fileName);
$variableCacheKey = sprintf('v3-%s', ComposerHelper::getPhpDocParserVersion());
$variableCacheKey = sprintf('v4-%s', ComposerHelper::getPhpDocParserVersion());
$cached = $this->loadCachedPhpDocNodeMap($cacheKey, $variableCacheKey);
if ($cached === null) {
[$nameScopeMap, $files] = $this->createPhpDocNodeMap($fileName, null, null, [], $fileName);
Expand Down Expand Up @@ -642,7 +642,7 @@ function (Node $node) use ($fileName, $lookForTrait, &$traitFound, $traitMethodA
$traitMethodAliases[$traitName] ?? [],
$originalClassFileName,
);
$nameScopeMap = array_merge($nameScopeMap, array_map(static fn ($originalNameScope) => $originalNameScope->getTraitData() === null ? $originalNameScope->withTraitData($fileName, $className, $traitName, $lookForTrait, $docComment) : $originalNameScope, $traitNameScopeMap));
$nameScopeMap = array_merge($nameScopeMap, array_map(static fn ($originalNameScope) => $originalNameScope->getTraitData() === null ? $originalNameScope->withTraitData($originalClassFileName, $className, $traitName, $lookForTrait, $docComment) : $originalNameScope, $traitNameScopeMap));
$files = array_merge($files, $traitFiles);
}
}
Expand Down
Loading