FileAnalyser: Move repetitive work out of hot loop #4758
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jan 14, 2026
| $error = $this->ruleErrorTransformer->transform($ruleError, $scope, $parserNodes, $node); | ||
|
|
||
| if ($error->canBeIgnored()) { | ||
| foreach ($this->ignoreErrorExtensionProvider->getExtensions() as $ignoreErrorExtension) { |
Contributor
Author
There was a problem hiding this comment.
this method was invoked once for every error found
ondrejmirtes
requested changes
Jan 14, 2026
| $error = $this->ruleErrorTransformer->transform($ruleError, $scope, $parserNodes, $node); | ||
|
|
||
| if ($error->canBeIgnored()) { | ||
| foreach ($this->ignoreErrorExtensionProvider->getExtensions() as $ignoreErrorExtension) { |
Member
There was a problem hiding this comment.
Could make sense to move it completely out of the callback and just use its variable? Maybe measure the memory difference.
Contributor
Author
There was a problem hiding this comment.
I cannot see a measurable improvement, even though this loop callback is invoked 800.000 times
staabm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.