Fix Makefile arginfo files generation rule #20891
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the mtime of the stub file is more recent than arginfo's one, but the content is unchanged, the build script will launch gen_stub.php without any effect, and attempt to do so over and over. By touching the arginfo file, we ensure that no more attempts are made unless the stub file is modified again.
Contributor
Author
|
What's the right target for this? I have more similar fixes to the build process coming up. |
Member
8.4 looks right. |
TimWolla
reviewed
Jan 10, 2026
| if test ! -z "$(PHP)"; then \ | ||
| echo Parse $< to generate $@;\ | ||
| $(PHP) $(top_srcdir)/build/gen_stub.php $<; \ | ||
| touch $@; \ |
Member
There was a problem hiding this comment.
Should the touch() rather be included in gen_stub.php to make it self-contained?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the mtime of the stub file is more recent than arginfo's one, but the content is unchanged, the build script will launch gen_stub.php without any effect, and attempt to do so over and over.
By touching the arginfo file, we ensure that no more attempts are made unless the stub file is modified again.