This repository was archived by the owner on Aug 11, 2020. It is now read-only.
iOS - tracking of disappearing event when swiping out the scanning dialog#881
Open
inverplax wants to merge 1 commit intophonegap:masterfrom
Open
iOS - tracking of disappearing event when swiping out the scanning dialog#881inverplax wants to merge 1 commit intophonegap:masterfrom
inverplax wants to merge 1 commit intophonegap:masterfrom
Conversation
inverplax
changed the title
inverplax
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to solve the swipe-out action on ios 13, I thought it was a good idea to trigger a closing of the scanning session whe user swipe the dialog out.
I have added two properties in class CDVbcsProcessor
In the CDVbcsViewController class there is now a method viewWillDisappear that is triggered when the scanning dialog is about to close. When the dialog is about close and it doesn't happen due to a successful scan or a cancel of the dialog, then
the barcodeScanCancelled is invoked.