Fix for uncaught error of destroy method#181
Open
AttilaSATAN wants to merge 1 commit intophoboslab:masterfrom
Open
Fix for uncaught error of destroy method#181AttilaSATAN wants to merge 1 commit intophoboslab:masterfrom
AttilaSATAN wants to merge 1 commit intophoboslab:masterfrom
Conversation
patch for phoboslab#174 In the presence of options `video: false` or `audio: false`, `destroy()` method of player instance throws an error as ```js Uncaught TypeError: Cannot read property 'destroy' of undefined at Player.destroy (jsmpeg.min.js:formatted:264) ```
katietheqt-old
approved these changes
Dec 13, 2017
|
Would you be interested in software that automatically finds TypeErrors caused by corner cases like these options? I am building Fuzz Stati0n to do that (free for OSS) - please take a look and consider signing up for our newsletter to keep in touch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch for #174
In the presence of options
video: falseoraudio: false,destroy()method of player instance throws an error as