Throw on unsupported includes - #583
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
==========================================
+ Coverage 64.05% 64.33% +0.27%
==========================================
Files 59 59
Lines 1992 1999 +7
Branches 395 396 +1
==========================================
+ Hits 1276 1286 +10
+ Misses 573 572 -1
+ Partials 143 141 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
includesexpression now has to name a property marked with a join attribute, and anything else raises anArgumentExceptionnaming the property rather than being silently dropped from the query. Update with joins is also rejected for every provider except MySQL, sinceUPDATE t1 JOIN t2 ON ... SET ...is MySQL syntax that SQL Server, PostgreSQL, Oracle and SQLite all refuse to parse. Passing a join whose navigation property is null still works and simply skips that join, so nothing that generates valid SQL today starts throwing.Ref #581