Skip to content

Fix array Contains under C# 14 - #578

Merged
phnx47 merged 1 commit into
mainfrom
fix-array-contains-csharp14
Jul 24, 2026
Merged

Fix array Contains under C# 14#578
phnx47 merged 1 commit into
mainfrom
fix-array-contains-csharp14

Conversation

@phnx47

@phnx47 phnx47 commented Jul 24, 2026

Copy link
Copy Markdown
Owner

C# 14 binds array.Contains to MemoryExtensions.Contains, wrapping the collection in an implicit span conversion. The IN values resolved to null, silently degrading the predicate to IS NOT NULL. Unwrap the conversion and pin LangVersion to 14.0.

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.03%. Comparing base (d18ad3a) to head (3b8d0c3).

Files with missing lines Patch % Lines
src/SqlGenerator/ExpressionHelper.cs 62.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   64.08%   64.03%   -0.05%     
==========================================
  Files          59       59              
  Lines        1985     1991       +6     
  Branches      392      394       +2     
==========================================
+ Hits         1272     1275       +3     
- Misses        572      573       +1     
- Partials      141      143       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phnx47
phnx47 merged commit 499f9e1 into main Jul 24, 2026
5 of 7 checks passed
@phnx47
phnx47 deleted the fix-array-contains-csharp14 branch July 24, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant