ci: reduce the scope of acceptance test secrets#1137
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request simplifies secret management in GitHub Actions workflows by removing explicit secret passing and introducing an environment-based approach for acceptance tests. The changes reduce workflow complexity while maintaining security through GitHub's environment protection.
Changes:
- Removed secret definitions and passing for test credentials (
TEST_GITHUB_TOKEN,TEST_GITHUB_USER,TEST_GITHUB_PASSWORD,TEST_GITHUB_TOTP_SECRET) from workflow configurations - Added
environment: acceptance-testingto the acceptance test job to enable environment-level secret access - Streamlined workflow inputs by removing unused secret requirements
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/wc-build-push-test.yml |
Removed secret input definitions and passing to acceptance test workflow |
.github/workflows/wc-acceptance-test.yml |
Removed secret inputs and added environment property to test job |
.github/workflows/continuous-integration.yml |
Removed secret passing to build-push-test workflow |
|
Contributor
❌MegaLinter analysis: Error
Detailed Issues❌ ACTION / actionlint - 4 errors
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
Contributor
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
rjaegers
had a problem deploying
to
acceptance-testing
GitHub Actions
Failure
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Hey, I have created a Pull Request
Description of changes
This pull request refactors the GitHub Actions workflow configuration files to simplify secret handling and improve environment management for acceptance tests. The most significant changes are the removal of unused secret definitions and the introduction of a named environment for acceptance testing.
Workflow configuration cleanup:
TEST_GITHUB_TOKEN,TEST_GITHUB_USER,TEST_GITHUB_PASSWORD,TEST_GITHUB_TOTP_SECRET) from the job configuration in.github/workflows/continuous-integration.ymland.github/workflows/wc-build-push-test.ymlto reduce complexity and reliance on secrets that are no longer required. [1] [2].github/workflows/wc-acceptance-test.ymland.github/workflows/wc-build-push-test.yml, streamlining workflow inputs. [1] [2]Environment management improvement:
environment: acceptance-testingproperty to thetestjob in.github/workflows/wc-acceptance-test.ymlto enable better tracking and isolation of acceptance test runs.✔️ Checklist