Skip to content

reduce the usage of superclass with nil argument #19551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcusDenker wants to merge 1 commit into
base: Pharo14
Choose a base branch
from
+4 −10
Open

reduce the usage of superclass with nil argument #19551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Fuel-Core/FLTraitCluster.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ FLTraitCluster >> materializePostInstance: aTrait with: aDecoder [
initialize;
"#initialize sets Object as the superclass
but the superclass of traits is nil"
superclass: nil;
basicSuperclass: nil;
setName: name;
environment: environment.

Expand Down
12 changes: 3 additions & 9 deletions src/Traits-Tests/AbstractTraitsOnPreparedModelTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,8 @@ AbstractTraitsOnPreparedModelTest >> setUp [
AbstractTraitsOnPreparedModelTest >> setUpTranslatingRequiresFixture [
self c6: (self
newClass: #C6
superclass: ProtoObject
superclass: nil
traits: { }).
ProtoObject removeSubclass: self c6.
self c6 superclass: nil.
self c7: (self
newClass: #C7
superclass: self c6
Expand All @@ -257,21 +255,17 @@ AbstractTraitsOnPreparedModelTest >> setUpTranslatingRequiresFixture [
AbstractTraitsOnPreparedModelTest >> setUpTrivialRequiresFixture [
self c3: (self
newClass: #C3
superclass: ProtoObject
superclass: nil
traits: { }).
ProtoObject removeSubclass: self c3.
self c3 superclass: nil.
self c3 compile: 'foo ^self bla' classified: #accessing
]

{ #category : 'running' }
AbstractTraitsOnPreparedModelTest >> setUpTwoLevelRequiresFixture [
self c4: (self
newClass: #C4
superclass: ProtoObject
superclass: nil
traits: { }).
ProtoObject removeSubclass: self c4.
self c4 superclass: nil.
self c5: (self
newClass: #C5
superclass: self c4
Expand Down