Adding implicit prefix to Complishon#19459
Open
omarabedelkader wants to merge 3 commits intopharo-project:Pharo14from
Open
Adding implicit prefix to Complishon#19459omarabedelkader wants to merge 3 commits intopharo-project:Pharo14from
omarabedelkader wants to merge 3 commits intopharo-project:Pharo14from
Conversation
Contributor
Author
|
This PR willk fail in some of the tests |
omarabedelkader
changed the title
Member
|
Interesting change. Is it possible to add tests to validate this behavior? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It’s simple: today the engine both searches and inserts using the same full class name, so
SpPresenteronly appears if you typeSp...; the filter checks whether the candidate starts with what you typed, and accepting a result inserts the fullcontentsinto the editor.The role of this PR is to keep the real completion as
SpPresenter, but in package context let the matcher look at a shortened searchable form likePresenter, so typingPrecan still findSpPresenterwhile accepting it still inserts the full class name; that way we change only how a result is found, not how it is inserted.