Add save-to-server option for linelist exports#1805
Open
Conversation
joshsadam
added a commit
that referenced
this pull request
Apr 23, 2026
Contributor
Author
|
Addressed #1805 (comment). Fix in fe9f8b9 |
joshsadam
added a commit
that referenced
this pull request
Apr 23, 2026
Contributor
Author
|
Addressed #1805 (comment). Fix in 64c56ca |
joshsadam
added a commit
that referenced
this pull request
Apr 23, 2026
joshsadam
added a commit
that referenced
this pull request
Apr 23, 2026
8beff60 to
09b0161
Compare
joshsadam
added a commit
that referenced
this pull request
Apr 24, 2026
joshsadam
added a commit
that referenced
this pull request
Apr 24, 2026
09b0161 to
62817c1
Compare
ChrisHuynh333
requested changes
Apr 27, 2026
Collaborator
ChrisHuynh333
left a comment
There was a problem hiding this comment.
Seems to work well. In addition to what we discussed, just a couple phrasing things I think should be changed (up to you!)
Collaborator
|
Some issues to dig into:
|
joshsadam
added a commit
that referenced
this pull request
Apr 29, 2026
joshsadam
added a commit
that referenced
this pull request
Apr 29, 2026
070c2f6 to
1de9bc0
Compare
Contributor
Author
|
joshsadam
added a commit
that referenced
this pull request
Apr 29, 2026
joshsadam
added a commit
that referenced
this pull request
Apr 29, 2026
1de9bc0 to
05639d1
Compare
…rm field styles Co-authored-by: Copilot <copilot@github.com>
…ver checkbox Co-authored-by: Copilot <copilot@github.com>
Expose linelistExportRows with resolver that enforces export permissions and returns ordered rows backed by DataExports::LinelistExportRow. Includes GraphQL types and resolver tests.
Replace nodes(ids) sample fetch with namespaced export field, pass namespace_id from the main thread, and chunk by database sample ids.
05639d1 to
95d8b8e
Compare
… error translations in French
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do and why?
Adds a save-to-server option to the v2 linelist export dialog. Users can still download CSV/XLSX exports locally, or save the generated export as a ready data export that can be opened later from the data exports page.
This also adds GraphQL support for client-side linelist row loading, direct-upload-backed linelist export creation, and JavaScript test coverage for the v2 client export flow.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
bin/dev.http://localhost:3000/<group>/<project>/samples.bin/rails test test/graphql/create_linelist_data_export_test.rb test/graphql/linelist_export_rows_query_test.rb test/services/data_exports/linelist_create_service_test.rb bin/rails test:system test/system/data_exports_test.rb pnpm run test:js node --check app/javascript/controllers/linelist_export_controller.jsPR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.