Support PHP 8.5 and Symfony 8 components#98
Conversation
release 2.6
Updated Symfony package versions to support up to 8.0.
|
Thank you for the patch! Can you check, what's required to fix tests? Also, CI should be adjusted to test with v8 components. Could you update |
…'s below our supported PHP version anyway.
|
@mringler I've updated the CI workflow for Symfony 8 and removed Symfony 5, as it's below our PHP min version threshold anyway. It'd be nice to remove the CI workflow approvals so PRs can be completed all-at-once without delay. I'm betting these changes will throw some kind of error. The CS fixes are resolved though. |
|
Oh, yes, I thought once approved, all workflows of this PR will run without further approval. Apparently, you have to have at least one commit merged into the project. I don't think there is another option:
Soon... In the meantime, you can run the workflow at your own fork through |
…in composer.json during tests
…ty and clean up whitespace in ObjectBuilder.php
…Symfony 8 compatibility
… updating parameter handling for Date, Length, Regex, Type, and Unique constraints.
…tibility by mapping generic messages to specific parameters.
|
Okay, can't say I had a good time with this one. But it should be ready now. PHP 8.5 and Symfony 8 support. A couple things of note:
|
… underlying containers
|
@mringler Everything is updated. The CI had to be updated due to a docker versioning conflict in the actions containers. I guess that update happened overnight on Github's side. I've, instead, updated them to use services. You can read more about services here: |
mringler
left a comment
There was a problem hiding this comment.
Almost done. Very much awesome!
Thank you for adjusting ci.yml! Two questions below tough if you don't mind.
Finally, I'd prefer it if we could get rid of the trial-and-error commits, as they make it hard to figure out what really happened in a file. How comfortable are you with squashing and force pushing commits? I can completely squash them on merge, but it might make sense to keep some of this apart.
|
Regarding squash, you should enable squash and merge in the settings so the PR is squashed and merged into |
|
Alright, squashed and merged to develop. I'll finish up what's lying around and make the next release. Thank you for all the work and patience you put into this! It's great that we are up to current versions again. |

This PR adds support for PHP 8.5 and Symfony 8 components.