Skip to content

Support PHP 8.5 and Symfony 8 components#98

Merged
mringler merged 35 commits intoperplorm:developfrom
oojacoboo:patch-3
Feb 13, 2026
Merged

Support PHP 8.5 and Symfony 8 components#98
mringler merged 35 commits intoperplorm:developfrom
oojacoboo:patch-3

Conversation

@oojacoboo
Copy link
Copy Markdown

@oojacoboo oojacoboo commented Feb 7, 2026

This PR adds support for PHP 8.5 and Symfony 8 components.

mringler and others added 2 commits November 19, 2025 16:30
Updated Symfony package versions to support up to 8.0.
@mringler
Copy link
Copy Markdown
Collaborator

Thank you for the patch!

Can you check, what's required to fix tests?

Also, CI should be adjusted to test with v8 components. Could you update .github/workflows/ci.yml and add the symfony8-min and -max composer files (similar to tests/composer/composer-symfony7-min.json)?

@mringler mringler changed the base branch from main to develop February 11, 2026 13:45
@oojacoboo
Copy link
Copy Markdown
Author

oojacoboo commented Feb 11, 2026

@mringler I've updated the CI workflow for Symfony 8 and removed Symfony 5, as it's below our PHP min version threshold anyway.

It'd be nice to remove the CI workflow approvals so PRs can be completed all-at-once without delay. I'm betting these changes will throw some kind of error. The CS fixes are resolved though.

@mringler
Copy link
Copy Markdown
Collaborator

Oh, yes, I thought once approved, all workflows of this PR will run without further approval. Apparently, you have to have at least one commit merged into the project. I don't think there is another option:

Screenshot_2026-02-11_21-54-30

Soon...

In the meantime, you can run the workflow at your own fork through Actions in the toolbar, then CI on the left, then Run Workflow on the right (I think it should be https://github.com/oojacoboo/perpl/actions/workflows/ci.yml). I usually do this before creating PRs to avoid repeated notifications to watchers.

@oojacoboo
Copy link
Copy Markdown
Author

Okay, can't say I had a good time with this one. But it should be ready now. PHP 8.5 and Symfony 8 support.

A couple things of note:

  • We need instructions/docs/tooling for getting a local environment setup with local testing. I'm guessing this means docker infrastructure would be needed. But as is, the workflow is really painful for testing. I tried using act, but ran into some conflicts. I actually resolved many of them around composer and our custom test composer files. But gave up after a while. I think it's really close now though.
  • Validator\Constraints had to be adapted due to API changes in Symfony 8. These allow us to maintain BC with Propel's API.

@oojacoboo oojacoboo changed the title Update Symfony dependencies to include version 8.0 Support PHP 8.5 and Symfony 8 components Feb 12, 2026
Copy link
Copy Markdown
Collaborator

@mringler mringler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@oojacoboo
Copy link
Copy Markdown
Author

@mringler Everything is updated. The CI had to be updated due to a docker versioning conflict in the actions containers. I guess that update happened overnight on Github's side. I've, instead, updated them to use services. You can read more about services here:

https://docs.github.com/en/actions/tutorials/use-containerized-services/use-docker-service-containers

Copy link
Copy Markdown
Collaborator

@mringler mringler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done. Very much awesome!

Thank you for adjusting ci.yml! Two questions below tough if you don't mind.

Finally, I'd prefer it if we could get rid of the trial-and-error commits, as they make it hard to figure out what really happened in a file. How comfortable are you with squashing and force pushing commits? I can completely squash them on merge, but it might make sense to keep some of this apart.

@oojacoboo
Copy link
Copy Markdown
Author

Regarding squash, you should enable squash and merge in the settings so the PR is squashed and merged into master.

@mringler mringler merged commit 3d7d3fd into perplorm:develop Feb 13, 2026
76 checks passed
@mringler
Copy link
Copy Markdown
Collaborator

Alright, squashed and merged to develop. I'll finish up what's lying around and make the next release.

Thank you for all the work and patience you put into this! It's great that we are up to current versions again.

@oojacoboo oojacoboo deleted the patch-3 branch February 13, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants