Skip to content

Add string field for date columns and ColumnCodeProducer cleanup #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mringler wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add string field for date columns and ColumnCodeProducer cleanup #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
774a68e
Add string field for temporal columns and CodeProducer cleanup
mringler Mar 16, 2026
b3ae361
Disable broken Spryker sniffer rule
mringler Mar 16, 2026
9ea2e31
added column code references for new methods
mringler Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions phpcs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
<exclude name="Spryker.Commenting.DocBlockApiAnnotation"/> <!-- Another Spryker internal function. -->
<exclude name="Spryker.Commenting.DocBlockReturnSelf.InvalidChainable"/> <!-- methods with "@return $this" must end with "return $this", but cannot return $this through another method -->
<exclude name="Spryker.Commenting.DocBlockParamAllowDefaultValue.Typehint"/> <!-- fails to recognize array shapes (like `array{int, string})`-->
<exclude name="Spryker.Commenting.DocBlockParamAllowDefaultValue.WrongNullable"/> <!-- Checks for null as '?' (?string) but not '|null' (string|null) in spryker/code-sniffer 0.17.30 -->
</rule>

<rule ref="Spryker.Internal.SprykerDisallowFunctions">
Expand Down
8 changes: 3 additions & 5 deletions src/Propel/Generator/Builder/DataModelBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,13 +600,11 @@ public function declareClassFromBuilder(AbstractOMBuilder $builder, $aliasPrefix
/**
* @param string ...$classNames
*
* @return void
* @return array<string>
*/
public function declareClasses(string ...$classNames): void
public function declareClasses(string ...$classNames): array
{
foreach ($classNames as $class) {
$this->declareClass($class);
}
return array_map([$this, 'declareClass'], $classNames);
}

/**
Expand Down
Loading