Build model relation methods without ConnectionInterface param#119
Draft
mringler wants to merge 1 commit intoperplorm:mainfrom
Draft
Build model relation methods without ConnectionInterface param#119mringler wants to merge 1 commit intoperplorm:mainfrom
mringler wants to merge 1 commit intoperplorm:mainfrom
Conversation
|
@mringler nice! And yea, until the getter is clean, the model is still polluted with Propel specific implementation details. Meaning, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft for removing the
ConnectionInterfaceparameter from relation methods by setting configuration parametergenerator.omitConnectionInterfaceParameterOnRelationMethodstotrue.Example:
becomes
Not sure if this matches #41 as there is still the
?Criteria $criteria = nullparam.Manual setup passes sniffer and linter, but no tests yet.