Move query builder template code into template files#109
Merged
Conversation
|
Oh, this separation is a much better improvement. |
mringler
force-pushed
the
query_builder_templates
branch
from
75c8f01 to
f3937a6
Compare
mringler
force-pushed
the
query_builder_templates
branch
from
f3937a6 to
8cc9a6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cleanup around QueryBuilder, moved (almost) all of the template code that was sprinkled between class code into dedicated template files.
Also a bit of a step to the side, as the template files can be inconvenient when having to switch between Builder and template, but they are easier to read and so is QueryBuilder without the code strings.