Throw an error if non-existing service is used in a VHOST line#17
Open
eserte wants to merge 2 commits intoperlbal:masterfrom
Open
Throw an error if non-existing service is used in a VHOST line#17eserte wants to merge 2 commits intoperlbal:masterfrom
eserte wants to merge 2 commits intoperlbal:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is possible to assign a non-existing service to a VHOST line, e.g.
A request to example.org will be silently handled by my_service here. I think that Perlbal should complain instead. Unfortunately it does not seem to be possible to complain while the configuration is parsed, because the service definition can be done after the vhosts definition. But it is possible to complain when the non-existent service is about to be used.
Regards,
Slaven