Fix Windows path collision in hotel invoice data#2
Open
yishangupenn wants to merge 12 commits intomainfrom
Open
Fix Windows path collision in hotel invoice data#2yishangupenn wants to merge 12 commits intomainfrom
yishangupenn wants to merge 12 commits intomainfrom
Conversation
Co-authored-by: Minhajul Hoque <84698472+minh-hoque@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: minh-hoque <minh.hoque@gmail.com>
Co-authored-by: Tom Pakeman <tompakeman@openai.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Add author metadata for ryu-omnithrex so the GPT-5.4 prompting guide notebook displays proper attribution on cookbook.openai.com.
Co-authored-by: Annika Brundyn, Kathy Lau and Nish Singaraju
yishangupenn
pushed a commit
that referenced
this pull request
Mar 10, 2026
…89be-5bd8110247a2 Add CONTRIBUTORS.md file with comprehensive contributor acknowledgment
yishangupenn
pushed a commit
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a cross-platform checkout failure caused by a trailing-space path collision under:
examples/data/hotel_invoices/The repository previously contained two directory paths:
examples/data/hotel_invoices/extracted_invoice_json/examples/data/hotel_invoices/extracted_invoice_jsonThe second directory contained a trailing ASCII space in the name. Because both directories contained the same 31 filenames, Windows path normalization collapsed them into identical paths, causing checkout failures on native Windows environments.
This PR removes the trailing-space dataset tree and keeps the canonical dataset path already referenced in the repository:
examples/data/hotel_invoices/extracted_invoice_json/Additionally, this PR introduces a repository path portability guard and CI validation to prevent similar filesystem portability issues from occurring again.
Motivation
This change restores compatibility for contributors using native Windows environments.
Windows filesystems do not support path components that end with a trailing space. When both directories existed in the repository, Windows normalized them to the same path during checkout, causing failures such as:
This issue originated from commit:
ffdd52937d0c82d4fe3e85314ad88439c4a0e3cewhich was merged through:
PR #1273 – "Data Extraction & Transformation with GPT-4o"
openai#1273
The PR was opened and merged by charu-openai, with several content commits contributed by charuj and reviewed by msingh-openai.
Because Linux filesystems allow trailing-space directory names while Windows does not, the issue remained invisible until a Windows checkout attempted to materialize the working tree.
Changes in this PR
examples/data/hotel_invoices/extracted_invoice_jsonexamples/data/hotel_invoices/extracted_invoice_json.github/scripts/check_path_portability.py.github/workflows/validate-notebooks.yamlREADME.mdCONTRIBUTING.mdResult
After this change the repository is fully checkoutable on:
without requiring sparse checkout or filesystem workarounds.
The CI portability guard prevents similar path portability issues from being introduced in future commits.
For new content
This PR does not add new cookbook content and only addresses repository portability and infrastructure.
I have added a new entry in registry.yaml so that my content renders on the cookbook website.
I have conducted a self-review of my content based on the contribution guidelines:
Not applicable for this PR.