This repository was archived by the owner on Mar 16, 2024. It is now read-only.
Removal of repeated command and addition of missing one#206
Open
seepls wants to merge 2 commits intopercona:masterfrom
seepls:master
Open
Removal of repeated command and addition of missing one#206seepls wants to merge 2 commits intopercona:masterfrom seepls:master
seepls wants to merge 2 commits intopercona:masterfrom
seepls:master
Conversation
|
|
Contributor
EvgeniyPatlan
left a comment
EvgeniyPatlan
left a comment
There was a problem hiding this comment.
LGTM. @Sevlin please check
EvgeniyPatlan
approved these changes
Mar 9, 2020
Author
|
Can this be merged ? As this not past the CI test though. |
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reading the code for pmm-client and figured it had some repeated and one missing command . please review.