Do not write TAP output files to source dir#564
Open
jeltz wants to merge 1 commit intopercona:mainfrom
Open
Conversation
jeltz
changed the title
Now that we are using Meson it is even more annoying that some of our TAP tests write to t/results, so instead let's write them to testrun/*/results which is in the source director on make and in the build directory on Meson. And to make it more useful we make sure to output absolute paths on test failure so people easily can use diff.
jeltz
force-pushed
the
meson-mv-tap-result-files
branch
from
30ed8a0 to
82eb2f0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (76.24%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
==========================================
- Coverage 57.67% 57.65% -0.02%
==========================================
Files 68 68
Lines 10753 10753
Branches 2648 2648
==========================================
- Hits 6202 6200 -2
- Misses 3281 3285 +4
+ Partials 1270 1268 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we are using Meson it is even more annoying that some of our TAP tests write to
t/results, so instead let's write them totestrun/*/resultswhich is in the source director on make and in the build directory on Meson.And to make it more useful we make sure to output absolute paths on test failure so people easily can use diff.
@Naeem-Akhter @shahidullah79 @mohitj1988: would this change affect the QA workflows?