K8SPXC-1737: fix panic in reconcileReplication#2406
Open
Conversation
pooknull
requested review from
egegunes,
gkech,
hors,
mayankshah1607,
nmarukovich and
oksana-grishchenko
as code owners
egegunes
reviewed
Mar 30, 2026
pkg/controller/pxc/replication.go
Outdated
| } | ||
| is840 = compare840 >= 0 | ||
| } else { | ||
| is840 = version.Must(version.NewVersion(dbVer)).Compare(version.Must(version.NewVersion("8.4.0"))) >= 0 |
Contributor
There was a problem hiding this comment.
maybe we can assign this to a var at line 163 and shorten this line?
egegunes
changed the title
egegunes
approved these changes
Apr 6, 2026
Collaborator
commit: ccc095b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPXC-1737
DESCRIPTION
Problem:
reconcileReplication()may panic when.status.pxc.versioncontains an invalid pxc versionCause:
CompareMySQLVersion()does not validate.status.pxc.versionbefore parsing it.Solution:
Make
CompareMySQLVersion()return an error when.status.pxc.versionis empty or invalid. If.status.pxc.versionis empty, compare against the version read from the primary pod. Otherwise compare against the.status.pxc.version. If it is invalid, return an error and continue reconcile.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability