Conversation
Collaborator
commit: 53e742e |
egegunes
approved these changes
Mar 17, 2026
gkech
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPXC-1796
DESCRIPTION
Problem:
Container options are not applied to the xtrabackup sidecar.
Cause:
The PR that added the xtrabackup sidecar (#2274) did not implement support for container options. The sidecar attempted to parse the
CONTAINER_OPTIONSenv var, but it was never set.Solution:
Set env vars based on the container options. Use
XB_EXTRA_ARGS,XBCLOUD_EXTRA_ARGS, andXBSTREAM_EXTRA_ARGSto pass options to the corresponding binaries.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability