Skip to content

K8SPXC-1796: fix container options#2396

Open
pooknull wants to merge 3 commits intomainfrom
K8SPXC-1796
Open

K8SPXC-1796: fix container options#2396
pooknull wants to merge 3 commits intomainfrom
K8SPXC-1796

Conversation

@pooknull
Copy link
Copy Markdown
Contributor

@pooknull pooknull commented Mar 12, 2026

https://perconadev.atlassian.net/browse/K8SPXC-1796

DESCRIPTION

Problem:
Container options are not applied to the xtrabackup sidecar.

Cause:
The PR that added the xtrabackup sidecar (#2274) did not implement support for container options. The sidecar attempted to parse the CONTAINER_OPTIONS env var, but it was never set.

Solution:
Set env vars based on the container options. Use XB_EXTRA_ARGS, XBCLOUD_EXTRA_ARGS, and XBSTREAM_EXTRA_ARGS to pass options to the corresponding binaries.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PXC version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/L 100-499 lines label Mar 12, 2026
@JNKPercona
Copy link
Copy Markdown
Collaborator

Test Name Result Time
auto-tuning-8-0 passed 00:20:57
allocator-8-0 passed 00:14:14
allocator-8-4 passed 00:14:31
backup-storage-tls-8-0 passed 00:22:36
cross-site-8-0 passed 00:37:05
custom-users-8-0 passed 00:12:29
demand-backup-cloud-8-0 passed 01:00:57
demand-backup-cloud-8-4 passed 01:02:25
demand-backup-cloud-pxb-8-0 passed 00:58:28
demand-backup-encrypted-with-tls-5-7 passed 00:49:06
demand-backup-encrypted-with-tls-8-0 passed 00:48:11
demand-backup-encrypted-with-tls-8-4 passed 00:48:02
demand-backup-encrypted-with-tls-pxb-5-7 passed 00:19:00
demand-backup-encrypted-with-tls-pxb-8-0 passed 00:18:12
demand-backup-encrypted-with-tls-pxb-8-4 passed 00:18:58
demand-backup-8-0 passed 00:44:45
demand-backup-flow-control-8-0 passed 00:11:10
demand-backup-flow-control-8-4 passed 00:11:17
demand-backup-parallel-8-0 passed 00:09:33
demand-backup-parallel-8-4 passed 00:10:13
demand-backup-without-passwords-8-0 passed 00:15:15
demand-backup-without-passwords-8-4 passed 00:17:24
extra-pvc-8-0 passed 00:25:19
haproxy-5-7 passed 00:14:56
haproxy-8-0 passed 00:14:31
haproxy-8-4 passed 00:14:53
init-deploy-5-7 passed 00:16:17
init-deploy-8-0 passed 00:17:46
limits-8-0 passed 00:12:31
monitoring-2-0-8-0 passed 00:24:13
monitoring-pmm3-8-0 passed 00:18:32
monitoring-pmm3-8-4 passed 00:19:10
one-pod-5-7 passed 00:13:45
one-pod-8-0 passed 00:13:40
pitr-8-0 passed 00:47:55
pitr-8-4 passed 00:48:22
pitr-pxb-8-0 passed 00:47:28
pitr-pxb-8-4 passed 00:47:03
pitr-gap-errors-8-0 passed 00:48:51
pitr-gap-errors-8-4 passed 00:49:20
proxy-protocol-8-0 passed 00:09:27
proxy-switch-8-0 passed 00:14:11
proxysql-sidecar-res-limits-8-0 passed 00:08:37
proxysql-scheduler-8-0 passed 00:27:43
pvc-resize-5-7 passed 00:16:37
pvc-resize-8-0 passed 00:16:42
recreate-8-0 passed 00:18:34
restore-to-encrypted-cluster-8-0 passed 00:27:27
restore-to-encrypted-cluster-8-4 passed 00:28:13
restore-to-encrypted-cluster-pxb-8-0 passed 00:16:55
restore-to-encrypted-cluster-pxb-8-4 passed 00:17:09
scaling-proxysql-8-0 passed 00:08:55
scaling-8-0 passed 00:11:24
scheduled-backup-5-7 passed 01:04:33
scheduled-backup-8-0 passed 01:05:17
scheduled-backup-8-4 passed 01:06:44
security-context-8-0 passed 00:27:16
smart-update1-8-0 passed 00:34:44
smart-update1-8-4 passed 00:34:14
smart-update2-8-0 passed 00:39:34
smart-update2-8-4 passed 00:39:47
smart-update3-8-0 passed 00:18:12
storage-8-0 passed 00:10:30
tls-issue-cert-manager-ref-8-0 passed 00:09:48
tls-issue-cert-manager-8-0 passed 00:10:13
tls-issue-self-8-0 passed 00:14:30
upgrade-consistency-8-0 passed 00:12:49
upgrade-consistency-8-4 passed 00:12:32
upgrade-haproxy-5-7 passed 00:26:15
upgrade-haproxy-8-0 passed 00:26:47
upgrade-proxysql-5-7 passed 00:16:07
upgrade-proxysql-8-0 passed 00:15:53
users-5-7 passed 00:33:46
users-8-0 failure 00:00:57
users-scheduler-8-4 failure 00:00:55
validation-hook-8-0 passed 00:01:39
Summary Value
Tests Run 76/76
Job Duration 04:13:57
Total Test Time 32:04:55

commit: 53e742e
image: perconalab/percona-xtradb-cluster-operator:PR-2396-53e742e6

@egegunes egegunes added this to the v1.20.0 milestone Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants