Skip to content

K8SPS-661 | async clusters should not automatically start replication on startup#1272

Draft
mayankshah1607 wants to merge 3 commits intomainfrom
K8SPS-661
Draft

K8SPS-661 | async clusters should not automatically start replication on startup#1272
mayankshah1607 wants to merge 3 commits intomainfrom
K8SPS-661

Conversation

@mayankshah1607
Copy link
Copy Markdown
Member

CHANGE DESCRIPTION

Problem:
Short explanation of the problem.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

Signed-off-by: Mayank Shah <mayank.shah@percona.com>
Copilot AI review requested due to automatic review settings April 2, 2026 11:00
@pull-request-size pull-request-size bot added the size/XS 0-9 lines label Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the MySQL container entrypoint to prevent async clusters from automatically starting replication at mysqld startup, leaving replication start/stop fully controlled by the async orchestrator logic.

Changes:

  • Add skip-replica-start to the generated node.cnf when CLUSTER_TYPE=async.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mayankshah1607 and others added 2 commits April 2, 2026 16:33
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
Copilot AI review requested due to automatic review settings April 2, 2026 11:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@JNKPercona
Copy link
Copy Markdown
Collaborator

Test Name Result Time
async-ignore-annotations-8-4 passed 00:06:10
async-global-metadata-8-4 passed 00:15:51
async-upgrade-8-0 passed 00:12:37
async-upgrade-8-4 passed 00:14:12
auto-config-8-4 passed 00:26:12
config-8-4 passed 00:15:49
config-router-8-0 passed 00:07:03
config-router-8-4 passed 00:07:21
demand-backup-minio-8-0 passed 00:19:56
demand-backup-minio-8-4 passed 00:19:41
demand-backup-cloud-8-4 passed 00:25:04
demand-backup-retry-8-4 passed 00:15:14
demand-backup-incremental-8-0 passed 00:32:50
demand-backup-incremental-8-4 passed 00:36:06
async-data-at-rest-encryption-8-0 passed 00:14:08
async-data-at-rest-encryption-8-4 passed 00:14:14
gr-global-metadata-8-4 passed 00:15:31
gr-data-at-rest-encryption-8-0 passed 00:14:50
gr-data-at-rest-encryption-8-4 passed 00:14:57
gr-demand-backup-minio-8-4 passed 00:13:21
gr-demand-backup-cloud-8-4 passed 00:22:45
gr-demand-backup-haproxy-8-4 passed 00:09:34
gr-demand-backup-incremental-8-0 passed 00:35:34
gr-demand-backup-incremental-8-4 passed 00:35:43
gr-finalizer-8-4 passed 00:05:49
gr-haproxy-8-0 passed 00:04:50
gr-haproxy-8-4 passed 00:04:10
gr-ignore-annotations-8-4 passed 00:04:36
gr-init-deploy-8-0 passed 00:09:27
gr-init-deploy-8-4 passed 00:09:24
gr-one-pod-8-4 passed 00:05:47
gr-recreate-8-4 passed 00:17:00
gr-scaling-8-4 passed 00:07:58
gr-scheduled-backup-8-4 passed 00:19:32
gr-scheduled-backup-incremental-8-4 passed 00:22:08
gr-security-context-8-4 passed 00:09:22
gr-self-healing-8-4 passed 00:22:33
gr-tls-cert-manager-8-4 passed 00:08:42
gr-users-8-4 passed 00:05:24
gr-upgrade-8-0 passed 00:09:15
gr-upgrade-8-4 passed 00:09:40
haproxy-8-0 passed 00:09:07
haproxy-8-4 passed 00:08:19
init-deploy-8-0 passed 00:06:57
init-deploy-8-4 passed 00:05:39
limits-8-4 passed 00:07:18
monitoring-8-4 passed 00:13:51
one-pod-8-0 passed 00:06:33
one-pod-8-4 passed 00:05:51
operator-self-healing-8-4 passed 00:11:25
pvc-resize-8-4 passed 00:05:45
recreate-8-4 passed 00:12:59
scaling-8-4 passed 00:10:54
scheduled-backup-8-0 passed 00:16:07
scheduled-backup-8-4 passed 00:16:19
scheduled-backup-incremental-8-0 passed 00:22:02
scheduled-backup-incremental-8-4 passed 00:23:03
service-per-pod-8-4 passed 00:06:33
sidecars-8-4 passed 00:04:56
smart-update-8-4 passed 00:09:41
storage-8-4 passed 00:04:00
telemetry-8-4 passed 00:06:15
tls-cert-manager-8-4 passed 00:10:11
users-8-0 passed 00:07:34
users-8-4 passed 00:07:51
version-service-8-4 passed 00:20:38
Summary Value
Tests Run 66/66
Job Duration 02:04:33
Total Test Time 14:40:38

commit: 00ce3ce
image: perconalab/percona-server-mysql-operator:PR-1272-00ce3ce2

@hors hors added this to the v1.1.0 milestone Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS 0-9 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants