[pmm]: add support for initContainers#750
Conversation
KyriosGN0
requested review from
idoqo and
maxkondr
and removed request for
a team
|
hey @ademidoff @maxkondr, had to rebase the PR, could i get an approve and merge here? this would really help me out! |
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adds configurable initContainers support to the pmm Helm chart so users can run pre-start tasks (e.g., proxy setup) before the main PMM container starts.
Changes:
- Introduces a new
initContainersvalue invalues.yaml(defaulting to an empty list). - Renders
.Values.initContainersinto the PMM StatefulSet pod spec when provided. - Bumps chart version from
1.5.1to1.6.0.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
charts/pmm/values.yaml |
Adds the new initContainers configurable value (default []). |
charts/pmm/templates/statefulset.yaml |
Conditionally injects initContainers into the pod spec using .Values.initContainers. |
charts/pmm/Chart.yaml |
Chart version bump to reflect the new feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
hey @ademidoff, @maxkondr gentle ping for this PR, Thanks! |
|
hey @maxkondr, could you please merge my PR ? we would really like this feature! Thanks! |
|
We are quite reluctant to keep adding more variables to our Helm chart in cases where a simple configuration tweak can easily can be done in userland using tools such as kustomize. |
InitContainers are pretty ubiquitous in helm charts across the OSS field. In my case specifically we relay only on helm chart and argo. |
Signed-off-by: AvivGuiser avivguiser@gmail.com
fixes #749