[PPN-366] Enable scheduling ktr and kjb from VFS connections. Updates#361
Open
peterrinehart wants to merge 1 commit intopentaho:masterfrom
Open
[PPN-366] Enable scheduling ktr and kjb from VFS connections. Updates#361peterrinehart wants to merge 1 commit intopentaho:masterfrom
peterrinehart wants to merge 1 commit intopentaho:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates scheduler parameter handling so PDI (.ktr/.kjb) variable/parameter extraction can work with VFS-based inputs by passing richer file metadata through SchedulerService into SchedulerResourceUtil.
Changes:
- Extend
SchedulerService.InputFileInfoto expose the underlying file object viagetFile(). - Update
SchedulerServiceandSchedulerResourceUtilto route PDI parameter/variable discovery via either path (String) or file (Object) based on a PVFS flag. - Update unit tests to call the new
handlePDIScheduling(InputFileInfo, ...)signature.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| core/src/main/java/org/pentaho/platform/web/http/api/resources/services/SchedulerService.java | Adds getFile() to InputFileInfo and passes PVFS detection into PDI scheduling handling. |
| core/src/main/java/org/pentaho/platform/web/http/api/resources/SchedulerResourceUtil.java | Updates handlePDIScheduling to support PVFS by calling IPdiContentProvider with either path or file. |
| core/src/test/java/org/pentaho/platform/web/http/api/resources/SchedulerResourceUtilTest.java | Updates tests to use InputFileInfo with the new handlePDIScheduling method signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
core/src/main/java/org/pentaho/platform/web/http/api/resources/services/SchedulerService.java
Show resolved
Hide resolved
core/src/main/java/org/pentaho/platform/web/http/api/resources/SchedulerResourceUtil.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/pentaho/platform/web/http/api/resources/SchedulerResourceUtil.java
Show resolved
Hide resolved
core/src/main/java/org/pentaho/platform/web/http/api/resources/SchedulerResourceUtil.java
Show resolved
Hide resolved
the ScheduleResourceUtil to correctly call the PDIContentProvider to get variables and parameters from the ktr/kjb in a VFS location.
5336937 to
8393608
Compare
❌ Build failed in 1m 11sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl core❗ No tests found!Errors:Filtered log (click to expand)
ℹ️ This is an automatic message |
eddie-martinez
approved these changes
Feb 25, 2026
pentaho-whartman
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the ScheduleResourceUtil to correctly call the PDIContentProvider to get variables and parameters from the ktr/kjb in a VFS location.