Skip to content

[PPN-366] Enable scheduling ktr and kjb from VFS connections. Updates#361

Open
peterrinehart wants to merge 1 commit intopentaho:masterfrom
peterrinehart:PPN-366
Open

[PPN-366] Enable scheduling ktr and kjb from VFS connections. Updates#361
peterrinehart wants to merge 1 commit intopentaho:masterfrom
peterrinehart:PPN-366

Conversation

@peterrinehart
Copy link
Contributor

the ScheduleResourceUtil to correctly call the PDIContentProvider to get variables and parameters from the ktr/kjb in a VFS location.

Copilot AI review requested due to automatic review settings February 23, 2026 22:48
@buildguy

This comment has been minimized.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates scheduler parameter handling so PDI (.ktr/.kjb) variable/parameter extraction can work with VFS-based inputs by passing richer file metadata through SchedulerService into SchedulerResourceUtil.

Changes:

  • Extend SchedulerService.InputFileInfo to expose the underlying file object via getFile().
  • Update SchedulerService and SchedulerResourceUtil to route PDI parameter/variable discovery via either path (String) or file (Object) based on a PVFS flag.
  • Update unit tests to call the new handlePDIScheduling(InputFileInfo, ...) signature.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
core/src/main/java/org/pentaho/platform/web/http/api/resources/services/SchedulerService.java Adds getFile() to InputFileInfo and passes PVFS detection into PDI scheduling handling.
core/src/main/java/org/pentaho/platform/web/http/api/resources/SchedulerResourceUtil.java Updates handlePDIScheduling to support PVFS by calling IPdiContentProvider with either path or file.
core/src/test/java/org/pentaho/platform/web/http/api/resources/SchedulerResourceUtilTest.java Updates tests to use InputFileInfo with the new handlePDIScheduling method signature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

the ScheduleResourceUtil to correctly call the PDIContentProvider to get
variables and parameters from the ktr/kjb in a VFS location.
@buildguy
Copy link

❌ Build failed in 1m 11s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl core

❗ No tests found!

Errors:

Filtered log (click to expand)

script returned exit code 1

ℹ️ This is an automatic message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants