Open
Conversation
Contributor
jamesdoh0109
left a comment
jamesdoh0109
left a comment
There was a problem hiding this comment.
Can you version this change?
Member
Author
thanks. done |
Member
Author
|
I think we could set some sentry alert rules such that we send a notification to slack if an issue is >= a certain event level (maybe error) and another on frequency for lower event levels to reduce the slack spamming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clubs has been getting sentry alerts on invalid next parameters. The next parameter sanitisation seemed fine, but the alert level was set to error even though this was handled correctly. To address this, this PR lowers the level to warning. Depending on the sentry configs, we stop getting so many alerts on slack.