fix uuid genration#339
Open
michaelolbrich wants to merge 2 commits into
Open
Conversation
%x has not 'u' modifier. So %04ux was interpreted as an unsigned integer followed by a literal 'x'. Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
The order in which the arguments are evaluated seems to differ depending on the architecture. Since random32() is stateful, the result may be different. Use in the reverse order which seems to match what x86_64 does. Fixes: pengutronix#335 Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The string formatting was broken and the reproducible uuids not reproducible across architectures.