add aarch64 to systems

[yu-re-ka]

This allows nix run .#vm and nix run .#vm-rootless to work on aarch64-linux systems such as Apple Silicon Macs

[RobbieBuxton]

Thanks for the contribution @yu-re-ka! Just to double check, I assume you've verified locally this works on Apple Silicon?

[yu-re-ka]

Ran the following tests successfully:

• snapshotter
• push-n-pull
• kubernetes
• k3s-external

Failing tests:

• k3s (remote_image.go:167] "PullImage from image service failed" err="rpc error: code = Unimplemented desc = unknown service containerd.services.transfer.v1.Transfer" image="nix:0/nix/store/s3xs76345nl8pvcnaf3q2xk242j8prh2-nix-image-redis.tar:latest")
• k3s-rootless (same as k3s)
• gvisor (marked as broken)

on aarch64-linux

[RobbieBuxton]

I think there is an issue with the test runners atm, but I verified all the tests are still passing for x86 on my machine. It might be a good idea to have a table on the README showing support for different platforms now that we have more than one (i.e no gvisor or k3s on Apple Silicon) @elpdt852? Otherwise happy to merge!

[elpdt852]

I think we should do something like x86_64-linux.vm.

[RobbieBuxton]

Yeah I think this is nicer, otherwise I think this is ready to merge!

[RobbieBuxton]

Bump for @yu-re-ka, sorry if you've already seen this. Not sure if GitHub automatically notifies for comments.

[yu-re-ka]

nix run .#vm does work out of the box 14 Jun 2024 02:51:59 Edgar Lee ***@***.***>:

…

***@***.**** commented on this pull request. ---------------------------------------- In modules/nixos/default.nix[#140 (comment)]: > @@ -64,8 +64,10 @@ in { ``` */ flake.nixosConfigurations = { - vm = nixosSystemFor "x86_64-linux" ./vm.nix; - vm-rootless = nixosSystemFor "x86_64-linux" ./vm-rootless.nix; + vm-x86_64-linux = nixosSystemFor "x86_64-linux" ./vm.nix; I think we should do something like *x86_64-linux.vm*. Would prefer if *.#vm* just worked out of the box, so perhaps a shortcut like *vm = nixosSystemFor system* if there's a flake-equivalent of *builtins.system* that is pure. — Reply to this email directly, view it on GitHub[#140 (review)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AURNSZOD7DF53IZPXZWPKUTZHI5CZAVCNFSM6AAAAABJA7ZHHGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJXGIZTGNJQGI]. You are receiving this because you were mentioned. [Tracking image][https://github.com/notifications/beacon/AURNSZMTLJ2DKRMJ5DEV7IDZHI5CZA5CNFSM6AAAAABJA7ZHHGWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT6GJVV4.gif]

[elpdt852]

Regarding aarch64, I only want to merge this once its covered by CI. Will have to see if aarch64 github action workers are available.

[yuyuyureka]

Hi, I have rebased and added aarch64 to the build workflow matrix.

[yuyuyureka]

I don't know about larger runners with kvm support (the equivalent to the "nix-snapshotter-runner") to run the NixOS / integration tests.

[alexkirsz]

Hey @elpdt852, any chance this could be merged into main? Would be greatly appreciated 🙂