close #11 - quick word cloud of swear words of reddit comments - #13
close #11 - quick word cloud of swear words of reddit comments#13MarcinKosinski wants to merge 1 commit into
Conversation
pdrhlik
left a comment
There was a problem hiding this comment.
That's a great start! There are just a few comments I want you to go over. How do you structure the vignettes folder? Wouldn't it be better to create a folder for each vignette? It might get pretty messy when there are more like these. I honestly don't know the 'right' way to do this.
| Type: Package | ||
| Title: Database of Swear Words in R | ||
| Version: 0.0.0.9000 | ||
| Version: 0.0.0.9001 |
There was a problem hiding this comment.
I wouldn't change development versions. It moves pretty fast. I would keep this 0.0.0.9000 until ve decide on releasing something like v0.1.
|
|
||
|
|
||
| ```{r} | ||
| library(sweary);library(dplyr) |
There was a problem hiding this comment.
Put the library calls on separate lines.
| count(word) | ||
| ``` | ||
|
|
||
| ```{r} |
There was a problem hiding this comment.
Missing library(wordcloud2) here.
|
|
||
| ```{r} | ||
| library(RedditExtractoR) | ||
| reddit_comments <- |
There was a problem hiding this comment.
This piece of code produces a lot of mess while downloading the comments.
|
| | 0%
|
|====== | 4%
|
|=========== | 8%
We don't want that in the vignette.
@pdrhlik very quick application that boosted
Suggestssection I am not proud of. One would need to extend the vignette with some explanatory text that describes the code. Then such a vignette can be listed as an article if we ever go for bookdown pages, like this one http://www.sthda.com/english/rpkgs/survminer/articles/index.html