Skip to content

close #11 - quick word cloud of swear words of reddit comments - #13

Open
MarcinKosinski wants to merge 1 commit into
masterfrom
11-word-cloud-use-case
Open

close #11 - quick word cloud of swear words of reddit comments#13
MarcinKosinski wants to merge 1 commit into
masterfrom
11-word-cloud-use-case

Conversation

@MarcinKosinski

Copy link
Copy Markdown
Collaborator

image

@pdrhlik very quick application that boosted Suggests section I am not proud of. One would need to extend the vignette with some explanatory text that describes the code. Then such a vignette can be listed as an article if we ever go for bookdown pages, like this one http://www.sthda.com/english/rpkgs/survminer/articles/index.html

@pdrhlik pdrhlik left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great start! There are just a few comments I want you to go over. How do you structure the vignettes folder? Wouldn't it be better to create a folder for each vignette? It might get pretty messy when there are more like these. I honestly don't know the 'right' way to do this.

Comment thread DESCRIPTION
Type: Package
Title: Database of Swear Words in R
Version: 0.0.0.9000
Version: 0.0.0.9001

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't change development versions. It moves pretty fast. I would keep this 0.0.0.9000 until ve decide on releasing something like v0.1.

Comment thread vignettes/word_cloud.Rmd


```{r}
library(sweary);library(dplyr)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the library calls on separate lines.

Comment thread vignettes/word_cloud.Rmd
count(word)
```

```{r}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing library(wordcloud2) here.

Comment thread vignettes/word_cloud.Rmd

```{r}
library(RedditExtractoR)
reddit_comments <-

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of code produces a lot of mess while downloading the comments.

|
| | 0%
|
|====== | 4%
|
|=========== | 8%

We don't want that in the vignette.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants