docs(filter): Updates images for v6.#4338
Merged
nicolethoen merged 7 commits intopatternfly:mainfrom Jan 27, 2025
Merged
Conversation
dlabaj
reviewed
Oct 28, 2024
Contributor
dlabaj
left a comment
dlabaj
left a comment
There was a problem hiding this comment.
Looks like there's a build error.
...ntation-site/patternfly-docs/content/design-guidelines/usage-and-behavior/filters/filters.md
Outdated
Show resolved
Hide resolved
Collaborator
Contributor
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
Extreme nit but the arrow icon used in the images is different from the component implementation. I updated all the Figma examples to use fa-arrow-right Would you mind importing them one last time, please!
andrew-ronaldson
approved these changes
Jan 21, 2025
Contributor
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
You have resolved all my nitty gritty gripes without cursing my name (publicly). Thank you for the updates!
nicolethoen
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4324
I made some content edits when I felt like they were necessary to understand the images (or for obvious grammar and typos). But this page needs its own full-scale content cleanup as part of #3544. Planning to handle the rest in a follow-up