fix: Snapshot camera timestamps on the physics thread for ground truth accuracy#83
Open
Arcod7 wants to merge 1 commit into
Open
fix: Snapshot camera timestamps on the physics thread for ground truth accuracy#83Arcod7 wants to merge 1 commit into
Arcod7 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tempCaptureTime_->pendingCaptureTime_->captureTime_) in OpenGLView to safely pass the timestamp across thread boundaries to all camera types.Camera::getLastCaptureTime()so consumers can retrieve the simulation time of the last delivered frame.Camera::UpdateTransform()so its implemented again.drawingQueueMutex: the physics thread writestempCaptureTime_insideUpdateDrawingQueue, and the render thread reads it inPerformDrawingQueueCopyunder the same mutex.In this example, I'm building an Octomap from a Depth Camera, but Stonefish was giving me late timestamps for the Depth Camera. This caused a misalignment between the depth camera point cloud and the odometry pose, resulting in a distorted map (left). With the fix, timestamps match the actual pose commit, so the point cloud is correctly registered (right).