Skip to content

⚡ Bolt: [performance improvement] Replace Array.includes with Set in filters for O(N) lookups#145

Open
xb1g wants to merge 1 commit intomainfrom
bolt-optimize-array-filter-18138056828062593602
Open

⚡ Bolt: [performance improvement] Replace Array.includes with Set in filters for O(N) lookups#145
xb1g wants to merge 1 commit intomainfrom
bolt-optimize-array-filter-18138056828062593602

Conversation

@xb1g
Copy link
Copy Markdown
Collaborator

@xb1g xb1g commented Mar 23, 2026

💡 What: Replaced Array.prototype.includes with Set.prototype.has within .filter() loops across three files (app/api/classrooms/[id]/grading/route.ts, app/api/assignments/[id]/nodes/route.ts, and components/teams/StudentTeamDashboard.tsx).

🎯 Why: Using .includes() inside a .filter() loop results in an O(N * M) time complexity because for every item in the filtered array, the code scans the entire target array. By pre-computing a Set, the lookup becomes O(1), improving the overall operation to O(N + M). This is a classic Bolt optimization pattern.

📊 Impact: Reduces time complexity of array differences from O(N^2) to O(N). The exact real-world impact depends on the array size, but this avoids potentially severe bottlenecks as the application scales and classrooms/teams/assignments grow larger.

🔬 Measurement: Run pnpm test and ESLINT_USE_FLAT_CONFIG=false npx eslint to verify no regressions were introduced.


PR created automatically by Jules for task 18138056828062593602 started by @xb1g

Co-authored-by: xb1g <70068561+xb1g@users.noreply.github.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pseed Error Error Mar 23, 2026 3:58am

Request Review

@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant