-
Notifications
You must be signed in to change notification settings - Fork 2.3k
nodes: add modular cabinets and wall trim controls #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sudhir9297
wants to merge
68
commits into
pascalorg:main
Choose a base branch
from
sudhir9297:fix/wed-jul-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
3731eb3
Add roof surface placement support for items
sudhir9297 ed53bc2
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 fd8e02c
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 7c1e383
fixed conflict
sudhir9297 b3377da
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 f177a65
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 9af7491
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 fd27524
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 b516298
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 ebfc8ce
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 b7b313b
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 b2ad645
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 bffdb4a
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 ee7b10c
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 7d4b474
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 3a3318c
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 26df69f
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 5376e07
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 d2204aa
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 f2a5186
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 5841052
Merge branch 'main' of github.com:pascalorg/editor
sudhir9297 3b2e774
Add modular cabinet node
sudhir9297 92f2c25
Add modular cabinet run and tall cabinet workflows
sudhir9297 2b5964e
Add cabinet paint slots and material groups
sudhir9297 b1a7764
Improve modular cabinet presets and wall snapping
sudhir9297 0c64b77
Improve cabinet wall snapping
sudhir9297 21e6195
Fix cabinet wall snapping and countertop joins
sudhir9297 c6f3271
Improve cabinet appliance compartments
sudhir9297 b01df0e
Improve fridge visuals and smooth cabinet animations
sudhir9297 9608792
Improve gas hob flames and cooktop knob controls
sudhir9297 9ccfaad
Fix cabinet UVs and registry actions
sudhir9297 5691212
Merge remote-tracking branch 'upstream/main' into fix/wed-jul-1
sudhir9297 28eb570
Fix registry move snap typecheck
sudhir9297 eb171f9
Fix cabinet knob animation concurrency
sudhir9297 a2ab25d
Fix cabinet material disposal, undo flood, and 2D move parity
sudhir9297 89a284c
Restructure cabinet schema and centralize run math/mutations
sudhir9297 7b50f09
Add cabinet snap tests and split the cabinet panel
sudhir9297 306a87d
Split cabinet geometry.ts into per-appliance modules
sudhir9297 113c94d
Add undermount sink compartment with CSG-cut countertops
sudhir9297 4b9ba64
Update ifc-converter next-env reference to build-mode route types
sudhir9297 45cee0e
Draw cabinet floor plans with kitchen drafting symbols
sudhir9297 d528ec1
Play cabinet open/close animation on the E interaction key
sudhir9297 36f84d3
Add kitchen island and bar counter support to cabinet runs
sudhir9297 fff3cf5
Merge quick-action arrow and plus into one directional add glyph
sudhir9297 a2d63cb
Extend plugin discovery instead of replacing the host source
sudhir9297 ccaeae1
Add L-corner runs to modular cabinets with run-scoped grouping
sudhir9297 845cb01
Delete emptied cabinet run groups in the same delete gesture
sudhir9297 ea97e3a
Remove filler front gap treatment
sudhir9297 67d67e2
Apply architecture review fixes across cabinet, plugin-trees, and fra…
sudhir9297 42dc290
Propagate front styling to L-corner runs even when re-layout bails
sudhir9297 2417b47
Improve editor viewer integration
sudhir9297 baa5711
Refactor plugin panels and floorplan invalidation
sudhir9297 6b58b40
UV-unwrap and material-assign roof-segment trim planes
sudhir9297 592cc68
Fix cabinet placement snap feedback
sudhir9297 2938ab1
Add cabinet wall snap bypass
sudhir9297 267b4e2
Fix cabinet continuous placement flow
sudhir9297 16d3b97
Implement wall band material slots
sudhir9297 8a74f98
Add corner addition preview functionality and related tests
sudhir9297 aa2ba28
Fix cabinet and wall band behavior
sudhir9297 e72312b
Fix architecture review blockers
sudhir9297 800dc0d
Merge remote-tracking branch 'upstream/main' into fix/wed-jul-1
sudhir9297 d5c9a79
Fix post-merge quality check
sudhir9297 33d5cc2
fix cursor review feedback
sudhir9297 a6b0c27
Fix cabinet placement type and quick action history
sudhir9297 f3774e1
Improve cabinet placement feedback
sudhir9297 1c3a764
Make wall bands configurable
sudhir9297 7d704c7
Add wall trim profiles and default materials
sudhir9297 83163e6
Fix architecture review issues
sudhir9297 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import type { AnyNode, AnyNodeId } from '../schema/types' | ||
|
|
||
| export function selectionProxyIdFromMetadata(metadata: unknown): AnyNodeId | null { | ||
| if (!metadata || typeof metadata !== 'object' || Array.isArray(metadata)) return null | ||
| const value = (metadata as Record<string, unknown>).nodeSelectionProxyId | ||
| return typeof value === 'string' ? (value as AnyNodeId) : null | ||
| } | ||
|
|
||
| export function resolveSelectionProxyId( | ||
| node: AnyNode, | ||
| nodes: Readonly<Record<string, AnyNode | undefined>>, | ||
| ): AnyNodeId { | ||
| const proxyId = selectionProxyIdFromMetadata((node as { metadata?: unknown }).metadata) | ||
| if (!proxyId || !nodes[proxyId]) return node.id as AnyNodeId | ||
| return proxyId | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.