Skip to content

pretty_print screen-256color#251

Open
avirmaux wants to merge 1 commit intoparis-saclay-cds:masterfrom
avirmaux:patch-1
Open

pretty_print screen-256color#251
avirmaux wants to merge 1 commit intoparis-saclay-cds:masterfrom
avirmaux:patch-1

Conversation

@avirmaux
Copy link
Copy Markdown

Added screen-256color as TERM for which pretty_print may be usefull.

Added tmux TERM for pretty_print
@albertcthomas
Copy link
Copy Markdown
Collaborator

thanks @avirmaux, I'll test it on my side.

IS_WINDOWS = platform.system() == "Windows"
# known terminal types which can handle colors on any system
COLOR_TERMS = ['xterm-256color', 'cygwin', 'xterm-color']
COLOR_TERMS = ['xterm-256color', 'screen-256color', 'cygwin', 'xterm-color']
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working for me as is, I need to add screen

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
COLOR_TERMS = ['xterm-256color', 'screen-256color', 'cygwin', 'xterm-color']
COLOR_TERMS = ['xterm-256color', 'screen', 'screen-256color', 'cygwin', 'xterm-color']

@kegl
Copy link
Copy Markdown
Contributor

kegl commented Dec 15, 2021

@avirmaux @albertcthomas should we keep this open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants