fix: enforce string sorting key to handle mixed metadata types (#797)#801
Open
suhaniiz wants to merge 1 commit into
Open
fix: enforce string sorting key to handle mixed metadata types (#797)#801suhaniiz wants to merge 1 commit into
suhaniiz wants to merge 1 commit into
Conversation
|
@suhaniiz is attempting to deploy a commit to the param20h's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 PR Checklist
🔗 Related Issue
Closes #797
📝 What does this PR do?
Fixes a potential
TypeErrorcrash within the graph serialization sanitization pipeline (_convert_sets_for_json).When processing diverse document chunks, metadata keys like
pageorchunk_indexcan occasionally emerge with mixed primitive types (e.g., an integer page identifier14alongside an explicit textual page boundary descriptor"appendix_b"). When elements containing these variant types are collected into graph node/edge sets, calling Python's nativesorted()without a fallback comparator explicitly throws an unhandled error ('<' not supported between instances of 'str' and 'int').This PR introduces a uniform string representation key fallback (
key=str) within the sorting comprehensions, ensuring string-based sorting ordering evaluations complete predictably across heterogenous document indices without interruption.🗂️ Type of Change
🧪 How was this tested?
📸 Screenshots (if UI change)
N/A (Backend logic fix)
The sorting uses
key=strlazily inside the generator wrapper expressions. This gracefully yields an alphanumeric sort without throwing comparison evaluation errors, maintaining stability regardless of arbitrary source document structural discrepancies.✅ Self-Review Checklist
dev, notmainmainbranch or any HuggingFace deployment config