CI: Add Ruby 4.0 to CI Matrix#1547
Open
unochin wants to merge 1 commit intopaper-trail-gem:masterfrom
Open
Conversation
- Replace Ruby 3.4 with Ruby 4.0 in CI - Relax sqlite3 development dependency to avoid Gemfile/gemspec conflict - Bump actions/checkout from 4 to 6 - Document PaperTrail 17 compatibility in README - Fix RuboCop Layout/HeredocIndentation offenses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request adds Ruby 4.0 to the CI matrix.
It also includes the following changes:
Background for sqlite3 dependency change
When running
bundle exec appraisal installon Ruby 4.0, Bundler fails with the following error due to conflicting sqlite3 version constraints declared in the gemspec and the Appraisal Gemfiles:Relaxing the sqlite3 development dependency resolves this conflict and allows Appraisal to run successfully on Ruby 4.0.
Background for RuboCop lint errors
CI failed due to RuboCop lint errors after the RuboCop version was updated:
https://github.com/paper-trail-gem/paper_trail/actions/runs/21697428441/job/62570566123?pr=1547
The CI log reported the following autocorrectable Layout/HeredocIndentation offenses:
Therefore, I fixed them by running
bundle exec rubocop -a lib spec.Check the following boxes:
master(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.