MSSQL Compatibility

[samialfattani]

This PR address the issue that raises whenever the end user navigate to any page using MSSQL database. The MSSQL restricts using LIMIT and OFFSET without sorting,

• Some test cases are added using the paginations with single and muliple primary keys.
• The MSSQL docker container is added on port 1433.

[samialfattani]

tests are failing due to the missing of database conneciton with MSSQL, knowing that it suppposed to configured with devcontainer . can any one help and guide me how to activate the MSSQL divcontainer during the test ??

[ElLorans]

I silenced the warning in master, can you pull the latest changes?

[ElLorans]

Thanks for the great work! I do not see any change to functionality, so what was the issue?

[samialfattani]

Thanks for the great work! I do not see any change to functionality, so what was the issue?

to replicate the error:

1- Create a ModelView that connected to MSSQL Table includes more number of records to be paginated.
2- once the ModelView has no default sorting, the MSSQL will reject using LIMIT and OFFSET without ORDER BY clause.

[ElLorans]

But I cannot see where you fixed the issue. Sorry for being dense.

[samialfattani]

i can't see this either 😄 , honestly this PR gone throught many branches and local merges until i forget what i've done , maybe the issue is just addressed throught all perviouse PRs. Anyway, we can just consider this PR as enabling the use of MSSQL with a very limited test cases. later on, i will modify the /tests/sqla ALL functions to be parametrized so that they should be tested againest (postgres, mssql , and sqllite)

[ElLorans]

Is pymssql required? I do not see any import.
Since the tests are currently passing, I think we can directly remove this PR and parametrize the main db fixture.

[samialfattani]

Is pymssql required? I do not see any import.

Yes it is, SQLAlchmey impots it internally. without this PR MSSQL test won't pass since no container of MSSQL. this PR added container configuration for both devcontainer and github/workflow

[ElLorans]

I would then convert/close this PR to parametrize the db fixture, since the additional test can removed.

[samialfattani]

yes sure