Skip to content

Upstream 5.5.0#7

Open
michaeam wants to merge 19 commits intopallene-lang:upstreamfrom
michaeam:upstream
Open

Upstream 5.5.0#7
michaeam wants to merge 19 commits intopallene-lang:upstreamfrom
michaeam:upstream

Conversation

@michaeam
Copy link
Copy Markdown

  • From instructions in UPDATING.md
  • Minor fixes
  • Upstream merge to main and tagging (5.5.0) left to owner

hugomg added 18 commits May 14, 2022 19:41
Allow these functions to be used by extension modules
This way you can see if you are running a patched Lua
Merge all the internal headers. This makes life easier for our users
because they will only need to include a single header. Furthermore,
this avoids cluttering the /usr/include with lots of internal Lua
headers.
Since the core API can change after even a minor patch, we need a checkversion
function that looks at the LUA_VERSION_RELEASE_NUM. To avoid breaking
backwards compatibility, we introduce a new function instead of modifying
luaL_checkversion.
Also, add gen-lua-core.h to the makefile prerequesites of luacore.h,
to the latter is re-built whenever we change the former.
@hugomg
Copy link
Copy Markdown
Member

hugomg commented Apr 19, 2026

Hi Michael, thanks for contributing this.

I noticed that the commit message refers tk "minor fixes". Could you please clarify what those mean?

Additionally:

* Install missing llimits.h
* CORE header order change
* Generated luacore.h added to build
* Minor spell-fix
@michaeam
Copy link
Copy Markdown
Author

Hello Hugo. I've updated the PR, corrected another error, build & run-tested with pallene 5.5.0 (patch for pallene is WIP, some guessing needs to be better validated before PR) and hopefully a somewhat better commit header. with requested clarifications.

Here is a pallene trivial sanity test:

$ pallenec examples/arithmetic/arithmetic.pln
$ lua examples/arithmetic/main.lua 
1 + 2 = 3
1.5 - 3.25 = -1.75
$ 
$ lua -v
Lua 5.5.0  Copyright (C) 1994-2025 Lua.org, PUC-Rio

By this small contribution hoping to encourage your work and pallenes. Both which I think shows huge promise & potential.

Thanks!

@michaeam
Copy link
Copy Markdown
Author

Updated commit-header can be seen here: c27a0ca

@hugomg
Copy link
Copy Markdown
Member

hugomg commented Apr 28, 2026

Thanks, Michael. I'm back from the holidays now and I'm excited to see someone offering to contribute the update to 5.5.0!

Do you think it would be too difficult to refactor this PR so there is one commit that just brings merges in the upstream Lua stuff and a separate commit that contains only your customizations? That would make it easier to review the changes and would also help in the long term because sometimes we have to go back and look back at old commits to figure out exactly how Pallene differs from upstream Lua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants