[docs] Document OverflowList item key requirement#8164
Open
juliosuas wants to merge 3 commits into
Open
Conversation
Member
|
Thanks for your interest in palantir/blueprint, @juliosuas! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Generate changelog in
|
Contributor
Author
|
/changelog
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview💡 Improvements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the
visibleItemRendererkey requirement on the OverflowList docs page.Fixes #7746.
Testing
pnpm exec prettier --check packages/core/src/components/overflow-list/overflow-list.mdxgit diff --checkNotes
I also tried
pnpm docs-data, but it failed while generating docs fordatetime2because@blueprintjs/datetimecould not be resolved in this local environment, before any issue with this MDX change was reported.