chore/PIN-9521: align with design required field#1779
Merged
borgesis95 merged 2 commits intofeature/PIN-8882_soglie_differenziatefrom Mar 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces conditional required-field asterisk styling in shared React Hook Form inputs, and also includes a broader set of UI refactors, new “thank you” pages/routes, purpose load-estimation alerts, and a migration of build/CI tooling to pnpm.
Changes:
- Update RHF input components to style the required asterisk only when a field is actually required.
- Add publish “thank you” pages and new feedback routes; refactor multiple summary/detail sections and related translations/tests.
- Migrate build pipeline to pnpm (package.json, Dockerfile, GitHub workflows) and add new purpose “remaining daily calls” query/alerting.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/static/locales/en/common.json | Adds saveDocument label used by updated UI actions. |
| src/static/locales/en/attribute.json | Expands/updates attribute-related copy and new labels used by updated attribute UI. |
| src/router/routes.tsx | Adds new feedback routes for publish “thank you” pages. |
| src/pages/index.ts | Exports newly added publish “thank you” pages. |
| src/pages/PublishThankYouPage/index.ts | Adds barrel export for PublishThankYouPage. |
| src/pages/PublishThankYouPage/tests/PublishThankYou.page.test.tsx | Adds tests for PublishThankYouPage rendering/redirect/navigation. |
| src/pages/PublishThankYouPage/PublishThankYou.page.tsx | Implements generic publish “thank you” page driven by location state. |
| src/pages/ProviderPurposeDetailsPage/components/ProviderPurposeDetailsDailyCallsPlanCard.tsx | Tweaks layout/typography for daily calls plan card. |
| src/pages/ProviderPurposeDetailsPage/tests/ProviderPurposeDetailsGeneralInfoSection.test.tsx | Uses type-only import for Purpose. |
| src/pages/ProviderEServiceTemplateSummaryPage/components/index.ts | Re-exports summary sections with new names/structure. |
| src/pages/ProviderEServiceTemplateSummaryPage/components/ProviderEServiceTemplateVersionInfoSummary.tsx | Removes old version info summary component. |
| src/pages/ProviderEServiceTemplateSummaryPage/components/ProviderEServiceTemplateTechnicalSpecsSummarySection.tsx | Adds new technical specs summary section (interface + voucher lifespan). |
| src/pages/ProviderEServiceTemplateSummaryPage/components/ProviderEServiceTemplateGeneralInfoSummarySection.tsx | Renames/reshapes general info summary section content. |
| src/pages/ProviderEServiceTemplateSummaryPage/components/ProviderEServiceTemplateDocumentationSummary.tsx | Removes old documentation summary component. |
| src/pages/ProviderEServiceTemplateSummaryPage/components/ProviderEServiceTemplateAttributeVersionSummary.tsx | Removes old attribute version summary component. |
| src/pages/ProviderEServiceTemplateSummaryPage/components/ProviderEServiceTemplateAdditionalInfoSummarySection.tsx | Adds new additional info summary section (description/docs/manual approval). |
| src/pages/ProviderEServiceTemplateSummaryPage/tests/ProviderEServiceTemplateTechnicalSpecsSummarySection.test.tsx | Adds tests for new technical specs summary section. |
| src/pages/ProviderEServiceTemplateDetailsPage/components/ProviderEServiceTemplateDetailsTab/tests/ProviderEServiceTemplateDetailsTab.test.tsx | Adds tests for updated details tab composition. |
| src/pages/ProviderEServiceTemplateDetailsPage/components/ProviderEServiceTemplateDetailsTab/ProviderEServiceTemplateDetailsTab.tsx | Replaces attributes section with thresholds+attributes section and hides thresholds in technical section. |
| src/pages/ProviderEServiceTemplateCreatePage/components/EServiceTemplateCreateStepVersion/tests/EServiceTemplateCreateStepVersion.test.tsx | Adds tests for template “version” step UI. |
| src/pages/ProviderEServiceTemplateCreatePage/components/EServiceTemplateCreateStepThresholdsAndAttributes/index.ts | Adds export for thresholds+attributes creation step. |
| src/pages/ProviderEServiceTemplateCreatePage/components/EServiceTemplateCreateStepTechnicalSpecs/EServiceTemplateCreateStepTechnicalSpecsInterface.tsx | Renames interface step component/types; adjusts translation keys; simplifies wrapper styling. |
| src/pages/ProviderEServiceTemplateCreatePage/components/EServiceTemplateCreateStepPurpose/tests/EServiceTemplateCreateStepPurpose.test.tsx | Updates expected translation keys for purpose step. |
| src/pages/ProviderEServiceTemplateCreatePage/components/EServiceTemplateCreateStepPurpose/EServiceTemplateCreateStepPurposeAddPurposeTable.tsx | Updates i18n keyPrefix for purpose table section. |
| src/pages/ProviderEServiceTemplateCreatePage/components/EServiceTemplateCreateStepPurpose/EServiceTemplateCreateStepPurpose.tsx | Switches namespace to eserviceTemplate and updates i18n keys. |
| src/pages/ProviderEServiceTemplateCreatePage/components/EServiceTemplateCreateStepDocuments/EServiceTemplateCreateStepDocuments.tsx | Removes old template documents step component (refactor). |
| src/pages/ProviderEServiceTemplateCreatePage/components/EServiceTemplateCreateStepAttributes/EServiceTemplateCreateStepAttributes.tsx | Adds local form values type; wires AddAttributesToForm labels/actions for template creation. |
| src/pages/ProviderEServiceSummaryPage/components/index.ts | Updates exports and adds new summary sections (attributes/risk analysis). |
| src/pages/ProviderEServiceSummaryPage/components/tests/ProviderEServiceGeneralInfoSummary.instanceLabel.test.tsx | Updates test for new general info summary section and template query usage. |
| src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceVersionInfoSummarySection.tsx | Adds new version info summary section with doc downloads + manual approval. |
| src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceVersionInfoSummary.tsx | Removes old version info summary component. |
| src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceRiskAnalysisSummaryListSection.tsx | Renames risk analysis summary list component. |
| src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceGeneralInfoSummarySection.tsx | Adds new general info summary section supporting template-specific fields. |
| src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceGeneralInfoSummary.tsx | Removes old general info summary component. |
| src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceDocumentationSummarySection.tsx | Adds new documentation summary section (interface + audience + voucher lifespan). |
| src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceDocumentationSummary.tsx | Removes old documentation summary component. |
| src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceAttributeVersionSummarySection.tsx | Adds new attribute version summary section including thresholds + attribute groups. |
| src/pages/ProviderEServiceSummaryPage/components/ProviderEServiceAttributeVersionSummary.tsx | Removes old attribute version summary component. |
| src/pages/ProviderEServiceSummaryPage/tests/ProviderEServiceVersionInfoSummarySection.test.tsx | Adds tests for new version info summary section. |
| src/pages/ProviderEServiceSummaryPage/tests/ProviderEServiceRiskAnalysisSummaryListSection.test.tsx | Adds tests for renamed risk analysis summary list section. |
| src/pages/ProviderEServiceSummaryPage/tests/ProviderEServiceDocumentationSummarySection.test.tsx | Adds tests for new documentation summary section. |
| src/pages/ProviderEServiceSummaryPage/tests/ProviderEServiceAttributeVersionSummarySection.test.tsx | Adds tests for new attribute version summary section. |
| src/pages/ProviderEServiceListPage/components/EServiceTableRow.tsx | Replaces delegation chip with tooltip-based delegation indicator. |
| src/pages/ProviderEServiceListPage/ProviderEServiceList.page.tsx | Changes “create new” button icon. |
| src/pages/ProviderEServiceDetailsPage/components/ProviderEServiceDetailsTab/ProviderEServiceTechnicalInfoSection/ProviderEServiceTechnicalInfoSection.tsx | Swaps thresholds section component for voucher lifespan section component. |
| src/pages/ProviderEServiceDetailsPage/components/ProviderEServiceDetailsTab/ProviderEServiceDetailsTab.tsx | Renames descriptor attributes component import/usage. |
| src/pages/ProviderEServiceDetailsPage/components/ProviderEServiceDetailsTab/ProviderEServiceDescriptorAttributes.tsx | Removes old descriptor attributes component (refactor). |
| src/pages/ProviderEServiceDetailsPage/tests/ProviderEServiceDescriptorAttributesSection.test.tsx | Adds tests for new descriptor attributes section. |
| src/pages/ProviderEServiceCreatePage/components/sections/tests/EServiceVoucherSection.test.tsx | Adds tests for new voucher section (template vs non-template behavior). |
| src/pages/ProviderEServiceCreatePage/components/sections/tests/EServiceThresholdSection.test.tsx | Adds tests for new threshold section and suggested limits alert. |
| src/pages/ProviderEServiceCreatePage/components/sections/tests/EServiceTemplateInfoSection.test.tsx | Adds tests for new template info section. |
| src/pages/ProviderEServiceCreatePage/components/sections/tests/EServiceTemplateDetailsSection.test.tsx | Adds tests for new template details section (incl. personal data missing alert). |
| src/pages/ProviderEServiceCreatePage/components/sections/tests/EServiceInterfaceSection.test.tsx | Adds tests for new interface section (upload vs generate). |
| src/pages/ProviderEServiceCreatePage/components/sections/tests/EServiceInfoSection.test.tsx | Adds tests for new info section (editable vs readonly). |
| src/pages/ProviderEServiceCreatePage/components/sections/tests/EServiceDetailsSection.test.tsx | Adds tests for new details section (editable vs readonly). |
| src/pages/ProviderEServiceCreatePage/components/sections/tests/EServiceAttributesSection.test.tsx | Adds tests for attributes section prop wiring. |
| src/pages/ProviderEServiceCreatePage/components/sections/tests/DelegationSection.test.tsx | Adds tests for delegation section rendering. |
| src/pages/ProviderEServiceCreatePage/components/sections/SignalHubSection.tsx | Adds a SignalHub switch section for create flow with external links. |
| src/pages/ProviderEServiceCreatePage/components/sections/EServiceVoucherSection.tsx | Adds voucher lifespan + audience section with template readonly behavior. |
| src/pages/ProviderEServiceCreatePage/components/sections/EServiceThresholdSection.tsx | Adds thresholds section with validation and suggested limits alert. |
| src/pages/ProviderEServiceCreatePage/components/sections/EServiceTemplateInfoSection.tsx | Adds readonly template info section. |
| src/pages/ProviderEServiceCreatePage/components/sections/EServiceTemplateDetailsSection.tsx | Adds readonly template details section with personal data alert. |
| src/pages/ProviderEServiceCreatePage/components/sections/EServiceInterfaceSection.tsx | Adds interface section wrapper (upload or generate). |
| src/pages/ProviderEServiceCreatePage/components/sections/EServiceInfoSection.tsx | Adds service name/description section with external best-practice link. |
| src/pages/ProviderEServiceCreatePage/components/sections/EServiceDetailsSection.tsx | Adds technology/mode/personal-data section with radio groups and validations. |
| src/pages/ProviderEServiceCreatePage/components/sections/DelegationSection.tsx | Adds delegation configuration section with conditional checkbox subsection. |
| src/pages/ProviderEServiceCreatePage/components/components/UploadInterfaceDoc.tsx | Refactors interface upload component and surfaces error prop. |
| src/pages/ProviderEServiceCreatePage/components/EServiceCreateStepVersion/index.ts | Removes export (refactor). |
| src/pages/ProviderEServiceCreatePage/components/EServiceCreateStepThresholds/useAttributesCountersAlert.ts | Adds hook to compute attribute requirement counters and type labels. |
| src/pages/ProviderEServiceCreatePage/components/EServiceCreateStepThresholds/index.ts | Adds export for thresholds step. |
| src/pages/ProviderEServiceCreatePage/components/EServiceCreateStepThresholds/tests/EServiceCreateStepThresholds.test.tsx | Adds tests for thresholds step save behavior. |
| src/pages/ProviderEServiceCreatePage/components/EServiceCreateStepTechSpec/index.ts | Adds export for tech spec step. |
| src/pages/ProviderEServiceCreatePage/components/EServiceCreateStepInfoVersion/index.ts | Adds export for info version step. |
| src/pages/ProviderEServiceCreatePage/components/EServiceCreateStepInfoVersion/components/tests/UploadDocumentsSection.test.tsx | Adds tests for upload documents section behavior. |
| src/pages/ProviderEServiceCreatePage/components/EServiceCreateStepDocuments/index.ts | Removes exports (refactor). |
| src/pages/ProviderEServiceCreatePage/components/EServiceCreateStepDocuments/EServiceCreateStepDocuments.tsx | Removes old documents step component (refactor). |
| src/pages/ProviderEServiceCreatePage/components/EServiceCreateStepAttributes/index.ts | Removes export (refactor). |
| src/pages/ProviderEServiceCreatePage/components/EServiceCreateContext.tsx | Exports provider props type. |
| src/pages/ConsumerSimulateGetVoucherPage/components/VoucherInstructions/test/VoucherInstructions.test.tsx | Stabilizes i18n/Trans rendering in tests and updates expected keys. |
| src/pages/ConsumerPurposeSummaryPage/components/ConsumerPurposeSummaryRiskAnalysisAlertContainer.tsx | Extracts ruleset expiration alert UI into a component. |
| src/pages/ConsumerPurposeSummaryPage/components/ConsumerPurposeSummaryGeneralInformationAccordion.tsx | Adds remaining daily calls query + generic info alert in general info. |
| src/pages/ConsumerPurposeSummaryPage/tests/ConsumerPurposeSummary.page.test.tsx | Updates mocks and expected labels for new summary title/publish button/alerts. |
| src/pages/ConsumerPurposeSummaryPage/ConsumerPurposeSummary.page.tsx | Routes publish to thank-you page and uses extracted alert container; updates title/publish label. |
| src/pages/ConsumerPurposePublishThankYouPage/index.ts | Adds barrel export for consumer purpose publish thank-you page. |
| src/pages/ConsumerPurposePublishThankYouPage/ConsumerPurposePublishThankYou.page.tsx | Adds consumer purpose publish thank-you page. |
| src/pages/ConsumerPurposeFromTemplateEditPage/components/PurposeFromTemplateEditStepGeneral/PurposeFromTemplateEditStepGeneralForm.tsx | Replaces dailyCalls field with reusable load estimation section. |
| src/pages/ConsumerPurposeFromTemplateEditPage/tests/ConsumerPurposeFromTemplateEdit.page.test.tsx | Adds tests for template edit page required label/back button. |
| src/pages/ConsumerPurposeFromTemplateEditPage/ConsumerPurposeFromTemplateEdit.page.tsx | Adds required label typography above stepper. |
| src/pages/ConsumerPurposeEditPage/components/PurposeEditStepRiskAnalysis/RiskAnalysisForm/tests/RiskAnalysisForm.test.tsx | Updates accessible name expectations to use the asterisk marker. |
| src/pages/ConsumerPurposeEditPage/components/PurposeEditStepGeneral/PurposeEditStepGeneralForm.tsx | Marks required fields and uses load estimation section. |
| src/pages/ConsumerPurposeEditPage/ConsumerPurposeEdit.page.tsx | Adds RequiredTextLabel above step content. |
| src/pages/ConsumerPurposeDetailsPage/components/tests/ConsumerPurposeDetailsGeneralInfoSection.test.tsx | Adds tests for delegation/template fields display; imports React. |
| src/pages/ConsumerPurposeDetailsPage/components/PurposeDetailsTab/ConsumerPurposeDetailsLoadEstimateSection.tsx | Removes informational alert from details load estimation section. |
| src/pages/ConsumerPurposeDetailsPage/components/PurposeDetailsTab/ConsumerPurposeDetailsGeneralInfoSection.tsx | Adds styling to action links; shows consumer fields only when delegation exists. |
| src/pages/ConsumerPurposeDetailsPage/components/PurposeDetailsTab/ConsumerPurposeDetailsDailyCallsUpdatePlanCard.tsx | Small layout tweaks for update plan card. |
| src/pages/ConsumerPurposeDetailsPage/components/PurposeDetailsTab/ConsumerPurposeDetailsDailyCallsPlanCard.tsx | Icon/layout tweaks for plan card and action link styling. |
| src/pages/ConsumerPurposeDetailsPage/ConsumerPurposeDetails.page.tsx | Adjusts alert spacing. |
| src/pages/ConsumerPurposeCreatePage/tests/ConsumerPurposeCreate.page.test.tsx | Adds tests for create page title and required label. |
| src/pages/ConsumerPurposeCreatePage/ConsumerPurposeCreate.page.tsx | Adds RequiredTextLabel above create form. |
| src/pages/ConsumerEServiceTemplateDetailsPage/components/ConsumerEServiceTemplateDetails.tsx | Swaps attributes section for thresholds+attributes and hides thresholds in technical section. |
| src/pages/ConsumerEServiceDetailsPage/components/ConsumerEServiceDetailsTab/ConsumerEServiceDetailsTab.tsx | Removes signal hub section from consumer e-service details tab. |
| src/pages/ConsumerEServiceDetailsPage/components/ConsumerEServiceDetailsTab/ConsumerEServiceDescriptorAttributes.tsx | Adds thresholds subsection and attribute ownership data fetching. |
| src/hooks/useGetPurposeInfoAlert.ts | Adds hook to compute purpose info alert props from thresholds/residuals. |
| src/hooks/useGetProviderPurposesActions.ts | Updates provider purpose actions labels/variants. |
| src/hooks/useGetProviderEServiceTemplateActions.ts | Changes stepIndexDestination routing state when editing templates. |
| src/hooks/useGetProviderEServiceActions.ts | Removes stepIndexDestination from e-service edit navigation state. |
| src/hooks/tests/useResolveError.test.tsx | Switches createMemoryHistory import to history. |
| src/config/query-client.ts | Removes local MutationMeta augmentation and adjusts react-query imports. |
| src/components/shared/react-hook-form-inputs/RHFTextField.tsx | Adds conditional required-asterisk styling. |
| src/components/shared/react-hook-form-inputs/RHFSingleFileInput.tsx | Adds optional dropzoneLabel override. |
| src/components/shared/react-hook-form-inputs/RHFRadioGroup.tsx | Adds required prop and conditional required-asterisk styling on FormLabel. |
| src/components/shared/react-hook-form-inputs/RHFAutocomplete/_RHFAutocompleteBase.tsx | Adds placeholder prop and forwards required to TextField when rules require it. |
| src/components/shared/tests/UpdateVoucherDrawer.test.tsx | Adds tests for UpdateVoucherDrawer value conversion/submit/validation. |
| src/components/shared/tests/PurposeLoadEstimationSection.test.tsx | Adds tests for PurposeLoadEstimationSection and alert behavior. |
| src/components/shared/tests/ProviderThresholdsInfoAlert.test.tsx | Adds tests for ProviderThresholdsInfoAlert content. |
| src/components/shared/UploadDocumentsInterface.tsx | Refactors interface upload UI and adds error handling + label changes. |
| src/components/shared/UpdateThresholdsVoucherDrawer.tsx | Renames thresholds drawer to include voucher; updates i18n keyPrefix and types. |
| src/components/shared/UpdateAttributesDrawer.tsx | Improves group UI (titles, OR separators) and per-group autocomplete toggle state. |
| src/components/shared/ThankYouPage/index.ts | Adds barrel export for shared ThankYouPage component. |
| src/components/shared/ThankYouPage/tests/ThankYouPage.test.tsx | Adds tests for shared ThankYouPage. |
| src/components/shared/ThankYouPage/ThankYouPage.tsx | Adds reusable centered ThankYouPage layout component. |
| src/components/shared/SummaryInformationContainer.tsx | Adds helper wrapper to show a missing-info warning when content is absent. |
| src/components/shared/SummaryAccordion.tsx | Adds optional warning chip and updates summary header layout. |
| src/components/shared/RequiredTextLabel.tsx | Adds reusable required label component using error.dark color. |
| src/components/shared/PurposeLoadEstimationSection.tsx | Adds reusable daily calls input + residual/threshold alerts section. |
| src/components/shared/ProviderThresholdsInfoAlert.tsx | Adds alert showing provider thresholds and remaining values. |
| src/components/shared/InputWrapper.tsx | Adjusts helper text spacing styles. |
| src/components/shared/IconLink.tsx | Makes children optional. |
| src/components/shared/GreyAlert.tsx | Adds a grey-styled alert wrapper used in new sections. |
| src/components/shared/EserviceTemplate/index.ts | Replaces attributes export with thresholds+attributes export. |
| src/components/shared/EserviceTemplate/EServiceTemplateUpdateDocumentationDrawer.tsx | Renames internal form value types for clarity. |
| src/components/shared/EserviceTemplate/EServiceTemplateThresholdsSection.tsx | Switches to UpdateThresholdsVoucherDrawer and renames handler. |
| src/components/shared/EserviceTemplate/EServiceTemplateThresholdsAndAttributes.tsx | Adds combined thresholds+attributes section for templates. |
| src/components/shared/EserviceTemplate/EServiceTemplateThresholds.tsx | Adds small component to display thresholds or empty state. |
| src/components/shared/EserviceTemplate/EServiceTemplateTechnicalInfoSection.tsx | Adds voucher drawer editing section and supports hideThresholds. |
| src/components/shared/EserviceTemplate/EServiceTemplateAttributes.tsx | Refactors to accept attributes/actions props and adds “no attributes required” empty state. |
| src/components/shared/EmptySectionTextCard.tsx | Adds a simple card for empty text state display. |
| src/components/shared/DelegationTooltip.tsx | Adds tooltip delegation indicator used in provider list. |
| src/components/shared/AttributeAutocomplete.tsx | Updates button label key. |
| src/components/shared/AddAttributesToForm/tests/AddAttributesToForm.test.tsx | Adds tests for AddAttributesToForm behavior. |
| src/components/layout/containers/DocumentContainer.tsx | Layout tweak for action stack in document container. |
| src/components/layout/containers/AttributeGroupContainer.tsx | Allows ReactNode title and updates container colors. |
| src/components/layout/containers/AttributeContainer.tsx | Extends attribute container with thresholds/customization actions and adjusts details layout. |
| src/components/layout/Breadcrumbs.tsx | Tightens routeLabels typing and adds thank-you routes to hidden list. |
| src/components/dialogs/DialogTenantKindEserviceTemplate.tsx | Updates i18n keyPrefix for dialog strings. |
| src/api/purpose/purpose.services.ts | Adds getRemainingDailyCalls service (currently stubbed). |
| src/api/purpose/purpose.queries.ts | Adds getRemainingDailyCalls query helper. |
| src/api/purpose/purpose.mutations.ts | Updates confirmation dialog metadata. |
| src/api/eserviceTemplate/eserviceTemplate.mutations.ts | Fixes quotas mutation keyPrefix and varies publish confirm title by first/new version. |
| src/api/eservice/eservice.mutations.ts | Adds optional “threshold only” mutation feedback and varies publish confirm title/label. |
| scripts/open-api-type-generator.js | Updates generator option name to fileName. |
| package.json | Migrates to pnpm, pins certain versions, adjusts build scripts. |
| Dockerfile | Switches container build to pnpm with corepack and lockfile install. |
| .github/workflows/sonar-build-spec.yml | Migrates sonar build workflow to pnpm. |
| .github/workflows/ci.yml | Migrates CI workflow to pnpm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
129
to
136
Comment on lines
23
to
29
Comment on lines
286
to
291
Comment on lines
55
to
68
51eedf9
into
feature/PIN-8882_soglie_differenziate
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Issue
PIN-9521
📝 Description / Context
This PR updates required-field visual behavior in shared RHF form inputs, so the label asterisk (
*) is highlighted usingtheme.palette.error.darkonly when the field is actually required.The goal is to keep required indicators consistent across input types and avoid hardcoded behavior.
🛠 List of changes
RHFTextFieldto style.MuiFormLabel-asteriskwiththeme.palette.error.darkwhenrequiredis true (fallback to inherit otherwise).RHFRadioGroupwith the same conditional required-asterisk styling onFormLabel.🧪 How to test
RHFTextFieldandRHFRadioGroupwith both required and non-required fields.*in error dark color.