Skip to content

feature: resolving minor issues (github copilot comments) (PIN-9520)#1778

Open
antofo wants to merge 8 commits intofeature/PIN-8882_soglie_differenziatefrom
feature/PIN-9520_github-comments-resolution
Open

feature: resolving minor issues (github copilot comments) (PIN-9520)#1778
antofo wants to merge 8 commits intofeature/PIN-8882_soglie_differenziatefrom
feature/PIN-9520_github-comments-resolution

Conversation

@antofo
Copy link
Collaborator

@antofo antofo commented Mar 18, 2026

Jira Issue

PIN-9520

Context/Why

Resolving minor issues

  • Fix ui
  • Remove unused code
  • Resolve github copilot components

Key Changes

  • Replace { name: attribute.name } with { attributeName: attribute.name } in AttributeContainer to adjust translation.
  • Wrap DelegationTooltip icon in a span component with aria-label value
  • Change Box component to form in UploadDocumentsInterface and change button type to submit
  • Change step1Label to "General Information" instead of "General Informations"
  • Change e-service details voucher section title from "Durata del voucher e soglie" to "Voucher" (same thing for english translation)
  • Remove EServiceTemplateThresholdsSection and UpdateThresholdsVoucherDrawer components, which were unused, and remove any of their references/related test
  • Change readyonly variable to readonly in ConsumerEServiceTemplateDetails
  • Remove duplicated export in EServiceTemplate/index.ts
  • Add integer validation for thresholds input in EServiceThresholdSection, UpdateDailyCallsDrawer, CustomizeThresholdDrawer, EServiceTemplateCreateStepThresholdsAndAttributes
  • Remove useMemo for maxCustomThreshold in EServiceCreateStepThresholds

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
71.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants