Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
======================================
- Coverage 78% 69% -9%
======================================
Files 32 33 +1
Lines 3728 5012 +1284
======================================
+ Hits 2942 3506 +564
- Misses 786 1506 +720
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
357d225 to
1760d0a
Compare
41e9469 to
b62b9ea
Compare
Signed-off-by: JP-Ellis <josh@jpellis.me>
b62b9ea to
ed64107
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Separate out the FFI from the core Pact Python library.
🚨 Breaking Changes
The
pact.v3.ffimodule is replaced by thepact_ffipackage. The old module will alias the new one, so there will not be a breaking change for now; however, it is advised to replacepact.v3.ffi.{function}with the correspondingpact_ffi.{function}as the former will be removed in later versions.🔥 Motivation
To decouple the releases of FFIs from the core Pact Python functionality.
🔨 Test Plan
CI
🔗 Related issues/PRs